-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Autoresponder to Stripe #1675
Conversation
Bundle Size Diff
|
Plugin build for 97c87fe is ready 🛎️!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some small changes and few NITs, but overall it looks good.
E2E SummaryTyping
Values above 60ms"10 - 61.14" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an issue when you open one RichText area first and then open the other one, as seen here: https://www.loom.com/share/bb3e51015b9d433b809756a875f8f719
These steps work in opposite too, if you open the Autoresponder first and then Messages popup.
This was caused by the lack of a unique ID on the RichTextEditor component, thus the conflict on the same block since it reuse the component. 🔧 Added an area identifier property so we can properly separate the context. |
@Soare-Robert-Daniel Tested and found some small things, more like questions:
Regarding the functionality, everything works as expected 🚀 |
@AndreeaCristinaRadacina I do like the idea but right now the text saves as you type, so having a Save button won't serve any purpose. Let me know what you think. |
@HardeepAsrani, indeed, the popup works as expected. It was just a suggestion for more consistency, but it's not mandatory |
@irinelenache @HardeepAsrani, I added a small notification for the user to replace the placeholders. |
@Soare-Robert-Daniel The notice is a bit redundant, I can see from the Subject input that its placeholder and not value. I think it's fine without the notice. |
Notice is now removed. |
@Soare-Robert-Daniel Had another look and everything's ok here 👍 |
🎉 This PR is included in version 2.3.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closes #1611.
Summary
Add Autoresponder functions to Stripe Checkout
Workflow:
Screenshots
🟢 Pro not installed and license inactive -- Upsell
🟢 Pro installed and license inactive.
🟢 Pro installed and license active.
🟢 Default email message.
Test instructions
ℹ️ You will need a Stripe developer account & STMP connection (you can try WP SMTP plugin and GMAIL API)
⚠️ The placeholder for the body massage is not a traditional placeholder. If you change the message, it will be considered a value -- this is a limitation of the component.
ℹ️ You will put values for the subject and body. The values that you see as default are placeholders.
Checklist before the final review