Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Otter Tools Shortcuts #1378

Merged
merged 7 commits into from
Dec 12, 2022
Merged

Conversation

Soare-Robert-Daniel
Copy link
Contributor

Closes #1350.

Summary

Approved changes for Otter Tools toolbar:

  • remove the feedback button
  • shortcuts for Copy/Paste

Screenshots


Test instructions

Please make sure that the shortcuts are displayed and that they work.
⚠️ For Windows, you will need a machine for it. Browserstack does not seem to work well.


Checklist before the final review

  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Dec 6, 2022
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review December 6, 2022 15:01
@pirate-bot
Copy link
Contributor

pirate-bot commented Dec 6, 2022

Bundle Size Diff

Package Old Size New Size Diff
Animations 191.24 KB 191.24 KB 0 B (0.00%)
Blocks 1.26 MB 1.26 MB 839 B (0.06%)
CSS 6.65 KB 6.65 KB 0 B (0.00%)
Dashboard 43.59 KB 43.59 KB 0 B (0.00%)
Export Import 5.06 KB 5.06 KB 0 B (0.00%)
Pro 102.35 KB 102.35 KB 0 B (0.00%)

@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Plugin build for 49f0a3f is ready 🛎️!

@mghenciu
Copy link
Contributor

mghenciu commented Dec 8, 2022

For the Keyboard shortcuts, can't we use something inspired from Figma and/or Divi? Both of them work in a bunch of browsers.
Ctrl + Alt + C/V
CMD + Option + C/V
Shift + Alt + C/V

My assumption is that currently, as a user, I would need both hands to do a Copy Paste, and this may be annoying.

@Soare-Robert-Daniel
Copy link
Contributor Author

Update for MacOS: Ctrl+c copy and Ctrl+v paste

@pirate-bot
Copy link
Contributor

pirate-bot commented Dec 8, 2022

E2E Summary

Typing

Test Average Time (ms) Standard Deviation (ms) Median Time (ms) Quantile for soft limit (%) Quantile for hard limit (%)
Typing 54.61 17.71 49.75 81.82 (60ms) 98.99 (80ms)
Values above 60ms "2 - 60.60, 7 - 76.23, 11 - 76.13, 15 - 73.99, 16 - 67.29, 20 - 69.11, 21 - 68.67, 23 - 66.77, 24 - 75.46, 26 - 73.29, 27 - 63.19, 34 - 66.62, 40 - 77.30, 41 - 73.34, 42 - 66.42, 43 - 69.58, 93 - 208.53, 94 - 66.72"

@HardeepAsrani
Copy link
Member

For me, I couldn't get it to work on Mac either with Control + Command + J/K @Soare-Robert-Daniel

@Soare-Robert-Daniel
Copy link
Contributor Author

Soare-Robert-Daniel commented Dec 9, 2022

For me, I couldn't get it to work on Mac either with Control + Command + J/K @Soare-Robert-Daniel

Sorry, I forgot to update the displays for MacOS. The new shortcuts are those #1378 (comment)

@HardeepAsrani
Copy link
Member

@Soare-Robert-Daniel My bad, works for me now. Can you put it on QA if you're satisfied? Will be good to test it back all the way to 5.8 just to confirm.

@Soare-Robert-Daniel
Copy link
Contributor Author

I will after some testing on windows. Maybe we can find a better combination like on mac.

@Soare-Robert-Daniel
Copy link
Contributor Author

Update for Windows: Alt+c copy and Alt+x paste

@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Dec 12, 2022 that may be closed by this pull request
@irinelenache
Copy link
Contributor

@Soare-Robert-Daniel Tested and the shortcuts work fine for me with the latest version of Wordpress. If i'm using Wordpress 6.0 or lower, i will get this error when i try to add any block https://vertis.d.pr/i/TrqlIs

@Soare-Robert-Daniel
Copy link
Contributor Author

I added the MacOS detection function to our lib. Now should work on all WP versions.

@irinelenache
Copy link
Contributor

@Soare-Robert-Daniel Checked again and now everything's fine, thank you 🚀

@HardeepAsrani HardeepAsrani merged commit 8af285f into development Dec 12, 2022
@HardeepAsrani HardeepAsrani deleted the feat/otter-tools-improvements branch December 12, 2022 14:58
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Otter icon on the toolbar is too intrusive
5 participants