-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Otter Tools Shortcuts #1378
Otter Tools Shortcuts #1378
Conversation
Bundle Size Diff
|
Plugin build for 49f0a3f is ready 🛎️!
|
For the Keyboard shortcuts, can't we use something inspired from Figma and/or Divi? Both of them work in a bunch of browsers. My assumption is that currently, as a user, I would need both hands to do a Copy Paste, and this may be annoying. |
Update for MacOS: |
E2E SummaryTyping
Values above 60ms"2 - 60.60, 7 - 76.23, 11 - 76.13, 15 - 73.99, 16 - 67.29, 20 - 69.11, 21 - 68.67, 23 - 66.77, 24 - 75.46, 26 - 73.29, 27 - 63.19, 34 - 66.62, 40 - 77.30, 41 - 73.34, 42 - 66.42, 43 - 69.58, 93 - 208.53, 94 - 66.72" |
For me, I couldn't get it to work on Mac either with Control + Command + J/K @Soare-Robert-Daniel |
Sorry, I forgot to update the displays for MacOS. The new shortcuts are those #1378 (comment) |
@Soare-Robert-Daniel My bad, works for me now. Can you put it on QA if you're satisfied? Will be good to test it back all the way to 5.8 just to confirm. |
I will after some testing on windows. Maybe we can find a better combination like on mac. |
Update for Windows: |
@Soare-Robert-Daniel Tested and the shortcuts work fine for me with the latest version of Wordpress. If i'm using Wordpress 6.0 or lower, i will get this error when i try to add any block https://vertis.d.pr/i/TrqlIs |
I added the MacOS detection function to our lib. Now should work on all WP versions. |
@Soare-Robert-Daniel Checked again and now everything's fine, thank you 🚀 |
🎉 This PR is included in version 2.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closes #1350.
Summary
Approved changes for Otter Tools toolbar:
Screenshots
Test instructions
Please make sure that the shortcuts are displayed and that they work.
⚠️ For Windows, you will need a machine for it. Browserstack does not seem to work well.
Checklist before the final review