Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed filter control placeholder text #877

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Fixed filter control placeholder text #877

merged 2 commits into from
Mar 4, 2025

Conversation

girishpanchal30
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

I reset the FilterMatchType value when the user changed the exclusions type.

Closes #683

How to test the changes in this Pull Request:

  1. Open OPML settings.
  2. Click the Advanced menu button.
  3. Click the Exclusions submenu button.
  4. Choose Page URL as the condition and select the matches option.
  5. Now choose the Select filename option and ensure the placeholder displays word instead of path

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@pirate-bot
Copy link
Collaborator

Plugin build for aeb482f is ready 🛎️!

@girishpanchal30 girishpanchal30 requested a review from selul March 4, 2025 11:09
@girishpanchal30 girishpanchal30 linked an issue Mar 4, 2025 that may be closed by this pull request
@selul selul merged commit ba13250 into development Mar 4, 2025
11 checks passed
@selul selul deleted the fix/683 branch March 4, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stuck Placeholder Text
3 participants