Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development #95

Merged
merged 23 commits into from
Oct 30, 2023
Merged

Development #95

merged 23 commits into from
Oct 30, 2023

Conversation

cristian-ungureanu
Copy link
Contributor

@cristian-ungureanu cristian-ungureanu commented Oct 25, 2023 •
edited
Loading

Improvements

  • Dashboard Survey: Eliminated the feedback survey embedded within the dashboard.
  • Template Refinements: Incorporated header and footer elements into the 404 template.
  • Template Refinements: Applied the accent color as the background color to the penultimate section on the homepage.
  • Template Refinements: Integrated the site background color into the Featured Work section.
  • Style Enhancements: Introduced the Secondary Accent color in the main theme.json file and specified corresponding colors for each palette individually.

Bug Fixes

  • Editor Padding: Rectified the padding issue surrounding the page inside the editor.
  • Editor Styles View: Resolved the problem of sections expanding in height when previewing in Styles view on the homepage.

pirate-bot and others added 16 commits August 3, 2023 17:58
@pirate-bot
Sync branch [skip ci]
6b10004
@pirate-bot
Sync branch [skip ci]
aa43843
fix: growing height of patterns when browsing styles [#73]
c8a4d06
fix: unwanted padding inside the page editor [#54]
9db882b
@mghenciu
Adds accent color on testimonials section homepage
1ae8681
@mghenciu
Changes the Featured work bg color to site bg
ebd3403
@mghenciu
Adds header & footer on the 404 template
2d0918a
@dependabot
chore(deps-dev): bump automattic/vipwpcs from 2.3.3 to 2.3.4
8dfba25 
Bumps [automattic/vipwpcs](https://github.com/Automattic/VIP-Coding-Standards) from 2.3.3 to 2.3.4.
- [Release notes](https://github.com/Automattic/VIP-Coding-Standards/releases)
- [Changelog](https://github.com/Automattic/VIP-Coding-Standards/blob/develop/CHANGELOG.md)
- [Commits](Automattic/VIP-Coding-Standards@2.3.3...2.3.4)

---
updated-dependencies:
- dependency-name: automattic/vipwpcs
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
fix: multiple notifications at the same time [#69]
79d16aa
chore: disable survey notice
f9326be
chore: hide notice
d217b8a
@mghenciu
Adds secondary color and their values for each style
354dd65
@mghenciu
Adds secondary color for Crayola Global Palette
55657e9
@mghenciu
Cleans-up the Secondary palettes
02404ac
@dependabot
chore(deps): bump codeinwp/themeisle-sdk from 3.3.1 to 3.3.6
b8bf33e 
Bumps [codeinwp/themeisle-sdk](https://github.com/Codeinwp/themeisle-sdk) from 3.3.1 to 3.3.6.
- [Release notes](https://github.com/Codeinwp/themeisle-sdk/releases)
- [Changelog](https://github.com/Codeinwp/themeisle-sdk/blob/master/CHANGELOG.md)
- [Commits](Codeinwp/themeisle-sdk@v3.3.1...v3.3.6)

---
updated-dependencies:
- dependency-name: codeinwp/themeisle-sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Merge pull request #75 from Codeinwp/fix/padding-inside-editor
26a206a 
fix: unwanted padding inside the page editor [#54]
@github-actions
Copy link

github-actions bot commented Oct 25, 2023 •
edited
Loading

Plugin build for dedbc4b is ready 🛎️!

cristian-ungureanu added 7 commits October 25, 2023 15:47
Merge pull request #74 from Codeinwp/fix/growing-patterns
3dacb1a 
Fix growing height of patterns when browsing styles
Merge pull request #91 from Codeinwp/dependabot/composer/development/…
3bb4d02 
…codeinwp/themeisle-sdk-3.3.6

chore(deps): bump codeinwp/themeisle-sdk from 3.3.1 to 3.3.6
Merge pull request #83 from Codeinwp/fix/notifications-management
6d24fb1 
Fix notifications management
Merge pull request #80 from Codeinwp/dependabot/composer/development/…
21359e2 
…automattic/vipwpcs-2.3.4

chore(deps-dev): bump automattic/vipwpcs from 2.3.3 to 2.3.4
Merge pull request #79 from Codeinwp/fix/add-header-and-footer-on-the…
bfe8ee1 
…-404

Adds header & footer on the 404 template
Merge pull request #77 from Codeinwp/fix-/penultimate-section-backgro…
1696de8 
…und-on-homepage

Adds accent color on testimonials section homepage + changes
Merge pull request #93 from Codeinwp/adds-secondary-color
dedbc4b 
Adds secondary color and their values for each style
@JohnPixle
Copy link
Contributor

Hey, thanks for wrapping it up @cristian-ungureanu !
I will also take a look and test this and let you know 🚀

@cristian-ungureanu
Copy link
Contributor Author

Hey @JohnPixle, I'm currently waiting for a response from Mihai at this PR: #59.
As soon as that PR is merged, I'll ask QA to have another look before releasing it.

@JohnPixle
Copy link
Contributor

@cristian-ungureanu Thanks for these, I just tested them they look super.

Mihai has a day off today, but regarding #59 PR, I can confirm that it is ok to leave this out of this release for now. We will have the time to put more attention to these while we go through optimising the layouts in general.

I think you can pass this to QA. Let me know if you have any other clarifications! 🚀

@cristian-ungureanu
Copy link
Contributor Author

Ok, we'll have this tested, and if everything goes well, we'll release it on Monday 🚀

@irinelenache
Copy link
Contributor

@cristian-ungureanu Tested and everything's fine on my end 🚀

@JohnPixle
Copy link
Contributor

Hey friends 👋🏻

At some point today I think we can ship the release if everything is fine.
Let me know if I can help with something

cc @HardeepAsrani @mghenciu

@cristian-ungureanu cristian-ungureanu merged commit 8e2c885 into main Oct 30, 2023
5 checks passed
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cristian-ungureanu @JohnPixle @irinelenache @pirate-bot @mghenciu