Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds accent color on testimonials section homepage + changes #77

Merged

Conversation

mghenciu
Copy link
Contributor

Summary

  • Adds the accent color as background color to the Penultimate section on the homepage
  • adds site bg color to the Featured Work section. Currently Foreground color is used there

Will affect visual aspect of the product

YES

Screenshots

Before

Screen.Recording.2023-08-24.at.14.45.35.mov

After

Screen.Recording.2023-08-24.at.14.31.15.mov

Test instructions

  1. Install the new build
  2. Test if the Penultimate section (testimonials) uses the Accent color as background color
  3. and the section above that (Featured Work) should used the Site Background color - not foreground color
  4. Make sure it works ok on light and dark palettes

Closes #76

@mghenciu
Copy link
Contributor Author

✅ This is ready for review @HardeepAsrani , but I made it as Draft since I was getting the same error when trying to commit the changes made in the Templates.

@HardeepAsrani HardeepAsrani marked this pull request as ready for review August 24, 2023 12:10
@HardeepAsrani
Copy link
Member

@mghenciu Might have been a local issue, I don't see same issues being reported here.

@github-actions
Copy link

Plugin build for ebd3403 is ready 🛎️!

@mghenciu mghenciu added this to the 1.1.0 milestone Aug 24, 2023
@irinelenache
Copy link
Contributor

@mghenciu Tested the PR and everything's fine ✅

@JohnPixle JohnPixle removed this from the 1.1.0 milestone Sep 20, 2023
@cristian-ungureanu cristian-ungureanu merged commit 1696de8 into development Oct 25, 2023
9 checks passed
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the penultimate section background on the Homepage and adds accent background
6 participants