Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update translations #997

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Update translations #997

merged 4 commits into from
Nov 18, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Nov 15, 2024 •
edited
Loading

Summary

  • Remove old translations
  • Update some links to https
  • Add more context for translations on the requested strings.

Changed JS strings:

image

Changed PHP strings:
image

Will affect visual aspect of the product

NO

Check before Pull Request is ready:

Closes #978

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Nov 18, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Nov 18, 2024 that may be closed by this pull request
Prepare the plugin for localization #978
Open
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Nov 18, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review November 18, 2024 07:54
@pirate-bot
Copy link
Contributor

pirate-bot commented Nov 18, 2024 •
edited
Loading

Plugin build for 3c73da0 is ready 🛎️!

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Nov 18, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel merged commit 3b3021b into development Nov 18, 2024
8 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the fix/translations-review branch November 18, 2024 15:14
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 4.4.16 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abaicus abaicus Awaiting requested review from abaicus

Assignees

@Soare-Robert-Daniel Soare-Robert-Daniel

Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prepare the plugin for localization
2 participants
@Soare-Robert-Daniel @pirate-bot