fix: Yii2 ErrorHandler can not process when throw Error (#106) #107
Conversation
| // to expect error response codes in tests. | ||
| $app->errorHandler->discardExistingOutput = false; | ||
| $app->errorHandler->handleException($e); | ||
| } elseif (!$e instanceof ExitException) { |
There was a problem hiding this comment.
Was it necessary to remove this logic?
There was a problem hiding this comment.
No, see my comment in the issue itself. I am currently doubting whether the issue is valid at all.
| @@ -44,6 +44,16 @@ public function actionEnd() | |||
| \Yii::$app->end(); | |||
| } | |||
|
|
|||
| public function actionTypeError() | |||
There was a problem hiding this comment.
Please add a return type to any function you touch!
| public function testException(FunctionalTester $I) | ||
| { | ||
| $I->expectThrowable(new \Exception('This is not an HttpException'), function() use ($I) { | ||
| $I->amOnRoute('/site/exception'); | ||
| }); | ||
| $I->assertInstanceOf(Application::class, \Yii::$app); | ||
| $I->amOnRoute('/site/exception'); | ||
| $I->seeResponseCodeIsServerError(); | ||
| $content = $I->grabPageSource(); | ||
| $I->assertStringStartsWith("<pre>Exception 'Exception' with message 'This is not an HttpException'", $content); | ||
| } |
There was a problem hiding this comment.
Please add a return type to any function you touch!
| public function testTypeError(FunctionalTester $I) | ||
| { | ||
| $e = new \Exception('This is not an HttpException'); | ||
| \Yii::$app->params['throw'] = $e; | ||
| $I->expectThrowable($e, function() use ($I) { | ||
| $I->amOnRoute('/site/exception'); | ||
| }); | ||
| $I->amOnRoute('/site/type-error'); | ||
| $I->seeResponseCodeIsServerError(); | ||
| $content = $I->grabPageSource(); | ||
| $I->assertStringStartsWith('<pre>Exception 'TypeError' with message 'Cannot assign string to property', $content); | ||
| } |
There was a problem hiding this comment.
Please add a return type to any function you touch!
| $I->amOnRoute('/site/type-error'); | ||
| $I->seeResponseCodeIsServerError(); | ||
| $content = $I->grabPageSource(); | ||
| $I->assertStringStartsWith('<pre>Exception 'TypeError' with message 'Cannot assign string to property', $content); |
There was a problem hiding this comment.
I think it's better to check the string contains Cannot assign string to property. Instead of the full HTML snippet.
| // to expect error response codes in tests. | ||
| $app->errorHandler->discardExistingOutput = false; | ||
| $app->errorHandler->handleException($e); | ||
| } elseif (!$e instanceof ExitException) { |
There was a problem hiding this comment.
No, see my comment in the issue itself. I am currently doubting whether the issue is valid at all.
No description provided.