Skip to content

Commit

Permalink
Fix PHP 8.4 deprecation warnings (#109)
Browse files Browse the repository at this point in the history
  • Loading branch information
W0rma authored Dec 8, 2024
1 parent 108b200 commit 03af8d4
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ jobs:

strategy:
matrix:
php: [8.0, 8.1, 8.2]
php: [8.0, 8.1, 8.2, 8.3, 8.4]

steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand Down
2 changes: 1 addition & 1 deletion src/Codeception/Lib/Connector/Yii2.php
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ public function getCsrfParamName(): string
return $this->getApplication()->request->csrfParam;
}

public function startApp(\yii\log\Logger $logger = null): void
public function startApp(?\yii\log\Logger $logger = null): void
{
codecept_debug('Starting application');
$config = require($this->configFile);
Expand Down
4 changes: 2 additions & 2 deletions src/Codeception/Module/Yii2.php
Original file line number Diff line number Diff line change
Expand Up @@ -723,11 +723,11 @@ public function grabComponent(string $component): null|object
* $I->seeEmailIsSent(3);
* ```
*
* @param int $num
* @param int|null $num
* @throws \Codeception\Exception\ModuleException
* @part email
*/
public function seeEmailIsSent(int $num = null): void
public function seeEmailIsSent(?int $num = null): void
{
if ($num === null) {
$this->assertNotEmpty($this->grabSentEmails(), 'emails were sent');
Expand Down

0 comments on commit 03af8d4

Please sign in to comment.