Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Disclosure): remove aria-label #2926

Merged
merged 1 commit into from
Aug 19, 2024
Merged

fix(Disclosure): remove aria-label #2926

merged 1 commit into from
Aug 19, 2024

Conversation

dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Aug 16, 2024 •
edited
Loading

Overview

aria-label on disclosure was wiping out button text, this fixes that

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [ABC-123]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. head to disclosure story
  2. turn on VO
  3. hear the button announced when navigating with tab
  4. ...Profit!

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://66bfa91e9cb5a3a196653c57--gamut-preview.netlify.app

Deploy Logs

@dreamwasp dreamwasp marked this pull request as ready for review August 16, 2024 19:46
@dreamwasp dreamwasp requested a review from a team as a code owner August 16, 2024 19:46
aresnik11
aresnik11 approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@aresnik11 aresnik11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@dreamwasp dreamwasp added the Ship It :shipit: Automerge this PR when possible label Aug 19, 2024
@codecademydev codecademydev merged commit ad9c44f into main Aug 19, 2024
22 of 24 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Aug 19, 2024
@codecademydev codecademydev deleted the cass-gm-disclosure-qf branch August 19, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aresnik11 aresnik11 aresnik11 approved these changes

@BandanaKM BandanaKM Awaiting requested review from BandanaKM BandanaKM is a code owner automatically assigned from Codecademy/gamut

@LinKCoding LinKCoding Awaiting requested review from LinKCoding LinKCoding is a code owner automatically assigned from Codecademy/gamut

@JahazielGuzman JahazielGuzman Awaiting requested review from JahazielGuzman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dreamwasp @codecademydev @aresnik11