Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Gamut): update headings to sentence case #2907

Merged
merged 6 commits into from
Aug 13, 2024

Conversation

uxemilylee
Copy link
Contributor

@uxemilylee uxemilylee commented Jul 8, 2024

Overview

Update all headings in Gamut Storybook to sentence case for consistency with our Codecademy writing guidelines

PR Checklist

  • Related to designs: n/a
  • Related to JIRA ticket: GM-796
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env
Another Repo Another Link Another Env

First sentence case headings update in Badge
@CLAassistant
Copy link

CLAassistant commented Jul 8, 2024

CLA assistant check
All committers have signed the CLA.

@uxemilylee uxemilylee changed the title docs(Badge): update headings to sentence case docs(Gamut): update headings to sentence case Jul 12, 2024
Copy link
Contributor

@LinKCoding LinKCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!
Holding off on approval until we fix merge conflicts tho!

You can also feel free to change this PR from draft to ready for review!

@@ -21,7 +21,7 @@ In the following pages, you’ll find a collection of tips and tools for writing

## Resources

### External Tools & Resources:
### External tools and resources:

🖍 **[Hemingway App](https://hemingwayapp.com/):** Tool for checking copy for grade level and readability

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not sure why I can't commit directly below) but for the capitalize my title resource — should we omit that now?

Similarly is there any references/notes you want to make about heading titles and story names?

@dreamwasp dreamwasp marked this pull request as ready for review August 13, 2024 19:32
@dreamwasp dreamwasp requested a review from a team as a code owner August 13, 2024 19:32
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://66bbb6cfab6023a03e659a28--gamut-preview.netlify.app

Deploy Logs

@dreamwasp dreamwasp self-requested a review August 13, 2024 19:45
@dreamwasp dreamwasp added the Ship It :shipit: Automerge this PR when possible label Aug 13, 2024
@codecademydev codecademydev merged commit 5f5f649 into main Aug 13, 2024
17 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Aug 13, 2024
@codecademydev codecademydev deleted the el-gm-796-sentencecase branch August 13, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants