Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Edit] JavaScript Variables #5277

Merged
merged 13 commits into from
Oct 5, 2024
Merged

Conversation

smiosso
Copy link
Contributor

@smiosso smiosso commented Sep 17, 2024

Description

  • Added new codebite examples.

Issue Solved

Type of Change

  • Editing an existing entry (fixing a typo, bug, issues, etc)
  • Updating the documentation

Checklist

  • [ x] All writings are my own.
  • [x ] My entry follows the Codecademy Docs style guide.
  • [x ] My changes generate no new warnings.
  • [x ] I have performed a self-review of my own writing and code.
  • [x ] I have checked my entry and corrected any misspellings.
  • [ x] I have made corresponding changes to the documentation if needed.
  • [ x] I have confirmed my changes are not being pushed from my forked main branch.
  • [ x] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [ x] I have linked any issues that are relevant to this PR in the Issues Solved section.

@smiosso
Copy link
Contributor Author

smiosso commented Sep 17, 2024

Something went wrong, and I do not know why or how to fix it.

@Sriparno08 Sriparno08 self-assigned this Sep 17, 2024
@Sriparno08 Sriparno08 added enhancement New feature or request javascript JavaScript entries labels Sep 17, 2024
@Sriparno08
Copy link
Collaborator

No worries, @smiosso. The reviewers will fix it.

@smiosso
Copy link
Contributor Author

smiosso commented Sep 17, 2024 via email

Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @smiosso, thanks for contributing to Codecademy Docs!

I've listed all the modifications that you need to make in your entry below:

content/javascript/concepts/variables/variables.md Outdated Show resolved Hide resolved
content/javascript/concepts/variables/variables.md Outdated Show resolved Hide resolved
content/javascript/concepts/variables/variables.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @smiosso, this PR looks good for a second round of review!

Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to Codecademy Docs @smiosso 😄

The entry is ready to be merged! 🚀

@mamtawardhani mamtawardhani added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Oct 5, 2024
fixed lint issues
@mamtawardhani mamtawardhani merged commit 10677b3 into Codecademy:main Oct 5, 2024
6 checks passed
Copy link

github-actions bot commented Oct 5, 2024

👋 @smiosso
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/javascript/variables

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Edit] JavaScript Variables
3 participants