Skip to content

add postgresql functions concept #5220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 42 commits into from
Nov 28, 2024

Conversation

hakdo99
Copy link
Contributor

@hakdo99 hakdo99 commented Sep 16, 2024

Description

Add a concept entry about PostgreSQL functions. The new file is functions.md.

Issue Solved

Closes #4589

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@SaviDahegaonkar SaviDahegaonkar self-assigned this Sep 16, 2024
@SaviDahegaonkar SaviDahegaonkar added new entry New entry or entries postgresql PostgreSQL status: under review Issue or PR is currently being reviewed labels Sep 16, 2024
Copy link
Contributor

@SaviDahegaonkar SaviDahegaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hakdo99 ,
The entry is nicely written, and I have suggested a few changes. Please make them asap.

Thanks,
Savi

- 'PostgreSQL'
- 'Functions'
CatalogContent:
- 'learn-postgresql'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 'learn-postgresql'
- 'learn-postgresql'

Include only those course paths that are already available in the catalog-content.md file. You can add one if you want it to get included in the PR. Here learn-postgresql is not available in the catalog-content file so it makes it invalid to get included in PR.

@SaviDahegaonkar
Copy link
Contributor

Hey @NelsonSanti ,
Can I know if you have implemented the suggested changes so I can make it available for a second review?

@NelsonSanti
Copy link
Contributor

Hello @SaviDahegaonkar
it seems you were mistaken,
This job is not assigned to me.
No worries and thank you!

@SaviDahegaonkar
Copy link
Contributor

Hello @SaviDahegaonkar it seems you were mistaken, This job is not assigned to me. No worries and thank you!

Yeah, I am really sorry for the misunderstanding.

@SaviDahegaonkar
Copy link
Contributor

Hey @hakdo99 ,
Can I know if you have implemented the suggested changes so I can make it available for a second review?

Thanks,
Savi

Copy link
Contributor

@SaviDahegaonkar SaviDahegaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hakdo99 ,
LGTM! Thank You for Contributing to docs :)

Thanks,
Savi

Comment on lines 22 to 32
```pseudo
CREATE [OR REPLACE] FUNCTION function_name(parameters)
RETURNS return_type AS $$
DECLARE
<variable_name> <data_type>;
BEGIN
<function_logic>;
RETURN <value_or_variable>;
END;
$$ LANGUAGE lang_name;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```pseudo
CREATE [OR REPLACE] FUNCTION function_name(parameters)
RETURNS return_type AS $$
DECLARE
<variable_name> <data_type>;
BEGIN
<function_logic>;
RETURN <value_or_variable>;
END;
$$ LANGUAGE lang_name;
```pseudo
CREATE [OR REPLACE] FUNCTION function_name(parameters)
RETURNS return_type AS $$
DECLARE
<variable_name> <data_type>;
BEGIN
<function_logic>;
RETURN <value_or_variable>;
END;
$$ LANGUAGE lang_name;

@Radhika-okhade Radhika-okhade added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Nov 28, 2024
@Radhika-okhade Radhika-okhade merged commit 98fe840 into Codecademy:main Nov 28, 2024
6 checks passed
Copy link

👋 @hakdo99
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/postgresql/functions

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Concept Entry] Postgresql functions
5 participants