Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

concept entry sql rollback #5168 #5210

Merged
merged 15 commits into from
Oct 23, 2024
Merged

concept entry sql rollback #5168 #5210

merged 15 commits into from
Oct 23, 2024

Conversation

judygitsthejobdone
Copy link
Contributor

Description

New entry on the ROLLBACK concept in SQL under docs/content/sql/concepts/commands/rollback/rollback.md
Includes introduction, syntax, and examples for ROLLBACK and ROLLBACK TO SAVEPOINT.

This is my first contribution, done as part of the Learn Git & GitHub course on codecademy.

Issue Solved

Closes #5168

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

Note: yarn test is failing 1 test, displaying the below. I have double-checked the file structure and it is as requested, happy to oblige any requested changes to resolve.

Codecademy Docs Content › adheres to content file structure

expect(received).toBe(expected) // Object.is equality

Expected: ""
Received: "C:\Projects\Codecademy\Codecademy_docs\content\sql\concepts\commands\rollback\rollback.md - expected a directory but got a file"

@CLAassistant
Copy link

CLAassistant commented Sep 11, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@SaviDahegaonkar SaviDahegaonkar self-assigned this Sep 11, 2024
@SaviDahegaonkar SaviDahegaonkar added new entry New entry or entries sql SQL entries status: under review Issue or PR is currently being reviewed labels Sep 11, 2024
SaviDahegaonkar
SaviDahegaonkar requested changes Sep 14, 2024
View reviewed changes
Copy link
Collaborator

@SaviDahegaonkar SaviDahegaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Author,
I had a look at your file, I have suggested a few changes so make them asap.

content/sql/concepts/commands/rollback/rollback.md Outdated Show resolved Hide resolved
content/sql/concepts/commands/rollback/rollback.md Outdated Show resolved Hide resolved
content/sql/concepts/commands/rollback/rollback.md Outdated Show resolved Hide resolved
content/sql/concepts/commands/rollback/rollback.md Outdated Show resolved Hide resolved
content/sql/concepts/commands/rollback/rollback.md Outdated Show resolved Hide resolved
content/sql/concepts/commands/rollback/rollback.md Outdated Show resolved Hide resolved
SaviDahegaonkar
SaviDahegaonkar requested changes Sep 14, 2024
View reviewed changes
Copy link
Collaborator

@SaviDahegaonkar SaviDahegaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Author,
I had a look at your file, I have suggested a few changes so make them asap.

SaviDahegaonkar
SaviDahegaonkar requested changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@SaviDahegaonkar SaviDahegaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heu @judygitsthejobdone ,
I have suggested you some changes please make them asap.

Thanks,
Savi

content/sql/concepts/commands/rollback/rollback.md Outdated Show resolved Hide resolved
content/sql/concepts/commands/rollback/rollback.md Outdated Show resolved Hide resolved
SaviDahegaonkar
SaviDahegaonkar approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@SaviDahegaonkar SaviDahegaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Author,
LGTM!

Thanks,
Savi

content/sql/concepts/commands/rollback/rollback.md Outdated
ROLLBACK TO SAVEPOINT first;
SELECT * FROM table_1;

````
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
````

content/sql/concepts/commands/rollback/rollback.md Outdated
SET dob = "1/21/2024"
WHERE id = 2;
SELECT * FROM table_1;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

content/sql/concepts/commands/rollback/rollback.md Outdated
ROLLBACK TO SAVEPOINT first;
SELECT * FROM table_1;

````
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
````

@Sriparno08 Sriparno08 self-assigned this Oct 11, 2024
@Sriparno08 Sriparno08 added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Oct 11, 2024
Sriparno08
Sriparno08 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @judygitsthejobdone!

@Sriparno08 Sriparno08 merged commit c289266 into Codecademy:main Oct 23, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

👋 @judygitsthejobdone
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/sql/commands/rollback

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

@Sriparno08 Sriparno08 added status: review 2️⃣ completed hacktoberfest-accepted Indicates the PR was approved, merged, and pertains to Hacktoberfest and removed status: under review Issue or PR is currently being reviewed labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaviDahegaonkar SaviDahegaonkar SaviDahegaonkar approved these changes

@Sriparno08 Sriparno08 Sriparno08 approved these changes

Assignees

@Sriparno08 Sriparno08

@SaviDahegaonkar SaviDahegaonkar

Labels
hacktoberfest-accepted Indicates the PR was approved, merged, and pertains to Hacktoberfest new entry New entry or entries sql SQL entries status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Concept Entry] SQL ROLLBACK
4 participants
@judygitsthejobdone @CLAassistant @Sriparno08 @SaviDahegaonkar