-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Term Entry] Python Plotly-graph_objects .Mesh3d() #5201
Conversation
Your Name seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@FelixOmollo please sign the CLA, so that we can start with the review for this PR, thank you 😀 |
Hello, signed the CLA. Looking forward to your review. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @FelixOmollo thank you for contributing to Codecademy Docs, the entry is nicely written 😄
I've suggested a few changes, could you review and modify them at your earliest convenience? Feel free to discuss any concerns, thank you! 😃
Co-authored-by: Mamta Wardhani <[email protected]>
Co-authored-by: Mamta Wardhani <[email protected]>
Co-authored-by: Mamta Wardhani <[email protected]>
Co-authored-by: Mamta Wardhani <[email protected]>
Co-authored-by: Mamta Wardhani <[email protected]>
Hello Mamta, I have reviewed and committed your proposed changes. I would greatly appreciate your feedback. |
minor changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing to Codecademy Docs @FelixOmollo 😃
The entry looks good for a second round of review! 🚀
Hey @Sriparno08 looks like the author has made some commits with the local device ID as well, could you please help resolve this? Also, I'm done with the first review, assigning it to you for the second review. 😃 @FelixOmollo could you please visit this link and look through the process of adding your email id to your GitHub account. |
Okay @mamtawardhani, I'll take a look at it. |
8199e11
to
57d188f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @FelixOmollo!
Hey @FelixOmollo, have you visited this link and looked through the process of adding your email id to your GitHub account? If not, please do so that the entry can be merged. Note: If there's no response from your side in a week, this PR will be closed unfortunately. |
Closing this PR since the author is inactive. |
Description
-Added the Plotly-graph_objects .Mesh3d() module for Python.
Issue Solved
-Closes issue #5178
Type of Change
Checklist
main
branch.Issues Solved
section.