Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Term Entry] Python Plotly-graph_objects .Mesh3d() #5201

Closed
wants to merge 14 commits into from

Conversation

FelixOmollo
Copy link

Description

-Added the Plotly-graph_objects .Mesh3d() module for Python.

Issue Solved

-Closes issue #5178

Type of Change

  • Adding a new entry

Checklist

  • [x ] All writings are my own.
  • [ x] My entry follows the Codecademy Docs style guide.
  • [ x] My changes generate no new warnings.
  • [ x] I have performed a self-review of my own writing and code.
  • [ x] I have checked my entry and corrected any misspellings.
  • [x ] I have made corresponding changes to the documentation if needed.
  • [ x] I have confirmed my changes are not being pushed from my forked main branch.
  • [ x] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [x ] I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Sep 9, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ FelixOmollo
✅ Sriparno08
✅ mamtawardhani
❌ Your Name


Your Name seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mamtawardhani mamtawardhani self-assigned this Sep 9, 2024
@mamtawardhani
Copy link
Collaborator

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Your Name seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@FelixOmollo please sign the CLA, so that we can start with the review for this PR, thank you 😀

@mamtawardhani mamtawardhani added new entry New entry or entries status: under review Issue or PR is currently being reviewed plotly Python:Plotly entries labels Sep 9, 2024
@FelixOmollo
Copy link
Author

Hello, signed the CLA. Looking forward to your review. Thank you.

@mamtawardhani mamtawardhani linked an issue Sep 10, 2024 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @FelixOmollo thank you for contributing to Codecademy Docs, the entry is nicely written 😄

I've suggested a few changes, could you review and modify them at your earliest convenience? Feel free to discuss any concerns, thank you! 😃

@FelixOmollo
Copy link
Author

Hello Mamta, I have reviewed and committed your proposed changes. I would greatly appreciate your feedback.

minor changes
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to Codecademy Docs @FelixOmollo 😃

The entry looks good for a second round of review! 🚀

@mamtawardhani
Copy link
Collaborator

mamtawardhani commented Sep 11, 2024

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.✅ FelixOmollo✅ mamtawardhani❌ Your Name

Your Name seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Hey @Sriparno08 looks like the author has made some commits with the local device ID as well, could you please help resolve this? Also, I'm done with the first review, assigning it to you for the second review. 😃

@FelixOmollo could you please visit this link and look through the process of adding your email id to your GitHub account.

@Sriparno08
Copy link
Collaborator

Okay @mamtawardhani, I'll take a look at it.

@Sriparno08 Sriparno08 added status: under review Issue or PR is currently being reviewed and removed status: waiting for author labels Sep 11, 2024
@Sriparno08 Sriparno08 force-pushed the plotly-graph_objects branch 2 times, most recently from 8199e11 to 57d188f Compare September 20, 2024 15:48
Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @FelixOmollo!

@Sriparno08
Copy link
Collaborator

Hey @FelixOmollo, have you visited this link and looked through the process of adding your email id to your GitHub account? If not, please do so that the entry can be merged.

Note: If there's no response from your side in a week, this PR will be closed unfortunately.

@Sriparno08 Sriparno08 added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Sep 20, 2024
@Sriparno08
Copy link
Collaborator

Closing this PR since the author is inactive.

@Sriparno08 Sriparno08 closed this Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Term Entry] Python Plotly- graph_objects .Mesh3d()
4 participants