-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Entry} Added NumPy trace file #5200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @cigar-galaxy82 ,
The entry is nicely written, I have suggested some changes please make them asap.
Thanks,
Savi
Tags: | ||
- 'Arrays' | ||
- 'Functions' | ||
- 'Matrices' | ||
- 'NumPy' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tags: | |
- 'Arrays' | |
- 'Functions' | |
- 'Matrices' | |
- 'NumPy' | |
Tags: | |
- 'Arrays' | |
- 'Functions' | |
- 'Matrices' | |
- 'NumPy' |
Include only those tags that are present in the tags.md list and add one if it is not available in the list, Here Functions
is not present in the tags.md list you can add it first in the tags.md file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SaviDahegaonkar I believe the Functions tag is in the tags.md
## Syntax | ||
|
||
```pseudo | ||
numpy.trace(a, offset=0, axis1=0, axis2=1, out=None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
numpy.trace(a, offset=0, axis1=0, axis2=1, out=None) | |
numpy.trace(a, offset=0, axis1=0, axis2=1, out=None) |
Including a type parameter would make this syntax more accurate though it is not a necessary change.
Hi @SaviDahegaonkar I have made all the suggested changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @cigar-galaxy82 ,
LGTM! , I hereby approve this PR.
👋 @cigar-galaxy82 🎉 Your contribution(s) can be seen here: https://www.codecademy.com/resources/docs/numpy/built-in-functions/trace Please note it may take a little while for changes to become visible. |
Description
Issue Solved
#4480
Type of Change
Checklist
main
branch.Issues Solved
section.