Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Entry} Added NumPy trace file #5200

Merged
merged 6 commits into from
Sep 21, 2024

Conversation

cigar-galaxy82
Copy link
Contributor

@cigar-galaxy82 cigar-galaxy82 commented Sep 8, 2024

Description

Issue Solved

#4480

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@SaviDahegaonkar SaviDahegaonkar self-assigned this Sep 8, 2024
@SaviDahegaonkar SaviDahegaonkar added new entry New entry or entries numpy NumPy entries python Python entries status: under review Issue or PR is currently being reviewed labels Sep 9, 2024
Copy link
Collaborator

@SaviDahegaonkar SaviDahegaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cigar-galaxy82 ,
The entry is nicely written, I have suggested some changes please make them asap.

Thanks,
Savi

Comment on lines +7 to +11
Tags:
- 'Arrays'
- 'Functions'
- 'Matrices'
- 'NumPy'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Tags:
- 'Arrays'
- 'Functions'
- 'Matrices'
- 'NumPy'
Tags:
- 'Arrays'
- 'Functions'
- 'Matrices'
- 'NumPy'

Include only those tags that are present in the tags.md list and add one if it is not available in the list, Here Functions is not present in the tags.md list you can add it first in the tags.md file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SaviDahegaonkar I believe the Functions tag is in the tags.md

## Syntax

```pseudo
numpy.trace(a, offset=0, axis1=0, axis2=1, out=None)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
numpy.trace(a, offset=0, axis1=0, axis2=1, out=None)
numpy.trace(a, offset=0, axis1=0, axis2=1, out=None)

Including a type parameter would make this syntax more accurate though it is not a necessary change.

@cigar-galaxy82
Copy link
Contributor Author

Hi @SaviDahegaonkar I have made all the suggested changes

Copy link
Collaborator

@SaviDahegaonkar SaviDahegaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cigar-galaxy82 ,
LGTM! , I hereby approve this PR.

@SaviDahegaonkar SaviDahegaonkar merged commit 01dd0c8 into Codecademy:main Sep 21, 2024
6 checks passed
Copy link

👋 @cigar-galaxy82
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/numpy/built-in-functions/trace

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new entry New entry or entries numpy NumPy entries python Python entries status: review 1️⃣ completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants