This repository was archived by the owner on Oct 26, 2020. It is now read-only.
Nawal week 8 #1000
Open
Nawal week 8 #1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msachi
reviewed
Jul 4, 2020
| 2. Describe in a sentence what this API endpoint returns when all of the fields are completed? | ||
|
|
||
| <!-- Write your answer here --> | ||
| Lists details of a pull request by providing its number |
There was a problem hiding this comment.
Yes, and specifically pull request comments.
| // }) | ||
|
|
||
| const addGreeting = (greetingObj) => { |
There was a problem hiding this comment.
I would call the parameter greeting as it is technically a string, not an object.
| const containerList = ulElement.appendChild(liElement) | ||
| const imgList = liElement.appendChild(imgElement) | ||
|
|
||
| const getRandomDogImg= (dogImg) => { |
There was a problem hiding this comment.
This might be more appropriately called displayImage. Try to keep the indentation consistent.
| @@ -0,0 +1,41 @@ | |||
| function getImage(){ | |||
| fetch ('https://dog.ceo/api/breeds/image/random') | |||
There was a problem hiding this comment.
Cool, this works well!
How would you implement error handling? Remember you can do any DOM manipulation you like, so you can show any messaging to the user...
| @@ -0,0 +1,30 @@ | |||
| function getHumour(){ | |||
There was a problem hiding this comment.
As before - works well! Think about error handling.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your Details
Your Name: Nawal
Your City: North West
Your Slack Name: NawalC
Homework Details
Module:JS3
Week:2