Skip to content

Dependabot/npm and yarn/cross spawn 7.0.6 #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

bkarimii
Copy link
Contributor

@bkarimii bkarimii commented Apr 15, 2025

This is a:

  • ✨ New feature - new behaviour has been implemented
  • πŸ› Bug fix - existing behaviour has been made to behave
  • ♻️ Refactor - the behaviour has not changed, just the implementation
  • βœ… Test backfill - tests for existing behaviour were added but the behaviour itself hasn't changed
  • βš™οΈ Chore - maintenance task, behaviour and implementation haven't changed

Description

  • Purpose -
    Versions of the package cross-spawn before 7.0.5 are vulnerable to Regular Expression Denial of Service (ReDoS) due to improper input sanitization. An attacker can increase the CPU usage and crash the program by crafting a very large and well crafted string.
  • How to check -

Open the app in your browser

It must've been deployed successfully.

Make sure everything works like before β€” no errors, crashes, or missing things

This update doesn't change anything you see; it just improves some background processes

Links

Link to the project board ticket: #1054

Link to initial: dependabot PR

Author checklist

  • I have written a title that reflects the relevant ticket
  • I have written a description that says what the PR does and how to validate it
  • I have linked to the project board ticket (and any related PRs/issues) in the Links section
  • I have added a link to this PR to the ticket
  • I have made the PR to qa from a branch named <category>/<name>, e.g. feature/edit-spaceships or bugfix/restore-oxygen
  • I have completed the manual tests described here
  • I have requested reviewers here and in my team chat channel
  • I have spoken with my PM or TL about any parts of this task that may have become out-of-scope, or any additional improvements that I now realise may benefit my project
  • I have added tests, or new tests were not required
  • I have updated any documentation (e.g. diagrams, schemas), or documentation updates were not required

@bkarimii
Copy link
Contributor Author

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/cross-spawn-7.0.6 branch from 071bacb to 2f81379 Compare April 15, 2025 11:27
Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6.
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md)
- [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6)

---
updated-dependencies:
- dependency-name: cross-spawn
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@bkarimii bkarimii force-pushed the dependabot/npm_and_yarn/cross-spawn-7.0.6 branch from 2f81379 to e597efd Compare April 15, 2025 11:39
@bkarimii bkarimii self-assigned this Apr 15, 2025
@bkarimii bkarimii moved this from Code reviewed to πŸ‘€ In review in Dashboard/ITD/Volunteer form Backlog Apr 17, 2025
@AnnaFYZ AnnaFYZ moved this from πŸ‘€ In review to πŸ§ͺ In testing (QA) in Dashboard/ITD/Volunteer form Backlog Apr 22, 2025
@AnnaFYZ
Copy link
Contributor

AnnaFYZ commented Apr 22, 2025

@bkarimii could you please update the description how to check? you know we can't ran any CL commands for deployed version

Copy link
Contributor

@AnnaFYZ AnnaFYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app deployed and works as expected, no errors in developer console

@AnnaFYZ AnnaFYZ moved this from πŸ§ͺ In testing (QA) to πŸ’― QA approved in Dashboard/ITD/Volunteer form Backlog Apr 22, 2025
@bkarimii bkarimii moved this from πŸ’― QA approved to πŸ”’ In System Integration Testing (SIT) (Staging) in Dashboard/ITD/Volunteer form Backlog Apr 24, 2025
@bkarimii bkarimii merged commit 9909cc9 into staging Apr 24, 2025
3 checks passed
@bkarimii bkarimii moved this from πŸ”’ In System Integration Testing (SIT) (Staging) to βœ… Done (Master) in Dashboard/ITD/Volunteer form Backlog Apr 24, 2025
@bkarimii bkarimii moved this from βœ… Done (Master) to πŸ”’ In System Integration Testing (SIT) (Staging) in Dashboard/ITD/Volunteer form Backlog Apr 24, 2025
@bkarimii bkarimii moved this from πŸ”’ In System Integration Testing (SIT) (Staging) to βœ… Done (Master) in Dashboard/ITD/Volunteer form Backlog Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: βœ… Done (Master)
Development

Successfully merging this pull request may close these issues.

4 participants