Skip to content

NW6 | Fathi Kahin | JS2 | Codewars API project | Week 4 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

fhkahin
Copy link

@fhkahin fhkahin commented Jan 19, 2024

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for cyf-codewars-projects ready!

Name Link
🔨 Latest commit e6cda52
🔍 Latest deploy log https://app.netlify.com/sites/cyf-codewars-projects/deploys/65aab249dba67f00075ef346
😎 Deploy Preview https://deploy-preview-14--cyf-codewars-projects.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@SallyMcGrath SallyMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start.

${this.userData.ranks.overall.name}
</data>`;
<data>
<table>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this table valid? When you validated your HTML what did you find was missing?

</head>
<body>
<codewars-badge></codewars-badge>
<h1> Fathi's Codewars Data: </h1> <br>
<table>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a table? Is this tabular data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants