-
-
Notifications
You must be signed in to change notification settings - Fork 33
NW6 | Fathi Kahin | JS2 | Codewars API project | Week 4 #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
NW6 | Fathi Kahin | JS2 | Codewars API project | Week 4 #14
Conversation
✅ Deploy Preview for cyf-codewars-projects ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start.
${this.userData.ranks.overall.name} | ||
</data>`; | ||
<data> | ||
<table> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this table valid? When you validated your HTML what did you find was missing?
</head> | ||
<body> | ||
<codewars-badge></codewars-badge> | ||
<h1> Fathi's Codewars Data: </h1> <br> | ||
<table> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a table? Is this tabular data?
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.