Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOUTH AFRICA - ITP | Luke Manyamazi | Module-User-Focused-Data | Week 2 #230

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
+86 −26
Open

SOUTH AFRICA - ITP | Luke Manyamazi | Module-User-Focused-Data | Week 2 #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fc5ddfc
added form elements, name, email, color choice and size options
iSirluke Oct 16, 2024
c8ed7ef
fixed XL value
iSirluke Oct 16, 2024
4ebfbdb
added the date input
iSirluke Oct 16, 2024
ee9131d
added a form container
iSirluke Oct 16, 2024
b6adb3c
added css to form container and body
iSirluke Oct 16, 2024
031df7b
added LUke to the page title
Luke-Manyamazi Oct 16, 2024
b69ad37
removed instruction html comments
Luke-Manyamazi Oct 16, 2024
29c0dd1
removed trailing hashes on input and link elements
Luke-Manyamazi Oct 16, 2024
fc06a98
fixed the href for the styles sheet
Luke-Manyamazi Oct 16, 2024
5de8e34
added date min and max attributes
Luke-Manyamazi Oct 16, 2024
c3a627d
added validation on input elements
Luke-Manyamazi Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 59 additions & 26 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,61 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<title>My form exercise</title>
<meta name="description" content="">
<meta name="viewport" content="width=device-width, initial-scale=1">
<link rel="stylesheet" href="styles.css">
</head>
<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!-- try writing out the requirements first-->
</form>

</main>
<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>
</footer>
</body>

</html>
<head>
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<title>Luke form exercise</title>
<meta name="description" content="">
<meta name="viewport" content="width=device-width, initial-scale=1">
<link rel="stylesheet" href="styles.css">
</head>
<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<div class="form_container">
<form>
<div class="name">
<label for="name">Name: </label>
<input id="name" placeholder="Your name" type="text" required>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name field is only supposed to accept names with atleast two characters.

</div>
<br />
<div class="email">
<label for="email">Email: </label>
<input id="email" type="email" placeholder="Your email" required>
</div>
<div class="color">
<p>Please select your favorite color.</p>
<input type="radio" id="red" name="color" value="red">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Select elements do not have associated label elements. Please ensure that all input fields etc. Have lables it is important for accessibility.

<label for="red">Red</label><br />
<input type="radio" id="green" name="color" value="green">
<label for="green">Green</label><br />
<input type="radio" id="blue" name="color" value="blue">
<label for="blue">Blue</label><br />
</div>
<br />
<div class="size">
<label for="size_choice">Choose a size.</label>
<select name="size" id="size" required>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Touch targets do not have sufficient size or spacing. This is having an impact on your accessibility score.

<option value="select">Select a size</option>
<option value="extra_small">XS</option>
<option value="small">S</option>
<option value="medium">M</option>
<option value="large">L</option>
<option value="extra_large">XL</option>
<option value="extra_extra_large">XXL</option>
</select>
</div><br>
<div class="date">
<label for="date">Choose a deliver date.</label>
<input type="date" id="date" name="delivery_date" min="2024-10-16" max="2024-11-16" required>
</div>
</form>
</div>
</main>
<footer>

<h2>By Luke Manyamazi</h2>
</footer>
</body>
</html>
27 changes: 27 additions & 0 deletions Form-Controls/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
body {
width: 100%;
padding: 1em 1em 2em 3em;
font-family: 'Segoe UI', Tahoma, Geneva, Verdana, sans-serif;
background-color: aqua;
}

.form_container {
width: 700px;
height: 250px;
border-color: black;
border: 1px;
border-style: solid;
padding: 1em;
background-color: bisque;
}

input:valid {
border: 2px solid green;
background-color: #e6ffe6;
}

input:invalid {
border: 2px solid red;
background-color: #ffe6e6;
}