Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CYF-London | Fatma Arslantas | Module-User-Focused-Data | Week 2 #229

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AFatmaa
Copy link

@AFatmaa AFatmaa commented Oct 16, 2024

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

This PR implements a T-shirt order form with a valid HTML structure and styled form controls. The form has been tested and refined using Chrome DevTools to ensure responsiveness and accessibility.

Questions

Ask any questions you have for your reviewer.

Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for cyf-ufd ready!

Name Link
🔨 Latest commit b18df41
🔍 Latest deploy log https://app.netlify.com/sites/cyf-ufd/deploys/670fee1ac349390008c5191e
😎 Deploy Preview https://deploy-preview-229--cyf-ufd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AFatmaa AFatmaa added the Needs Review Participant to add when requesting review label Oct 16, 2024
@ShayanMahnam
Copy link

well done @AFatmaa !!
You can see your work deployed on a PR preview here

https://deploy-preview-229--cyf-ufd.netlify.app/form-controls/

@ShayanMahnam ShayanMahnam added 👀 Review Requirements Changes requested to meet requirements Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Oct 16, 2024
@AFatmaa
Copy link
Author

AFatmaa commented Oct 16, 2024

Thank you, Shayan! Would you like me to change anything else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 Review Requirements Changes requested to meet requirements Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants