Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CYF-ITP-Sheffield|Kazeem Hamzat|Module-User-Focused-Data|Week2 #218

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

CYF-ITP-Sheffield|Kazeem Hamzat|Module-User-Focused-Data|Week2 #218

wants to merge 4 commits into from
+130 −9

Conversation

HamzatKazeem
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@HamzatKazeem
Initial Commit
9dd0a78 
- Create form
style input type elements
@HamzatKazeem
Add validation controls to form element
bb6ca85 
-Use regex for pattern checking on input type
-autofocus on first input type
-style the buttons
@netlify Netlify
Copy link

netlify bot commented Oct 14, 2024 •
edited
Loading

✅ Deploy Preview for cyf-ufd ready!

Name Link
🔨 Latest commit 2bfbdc5
🔍 Latest deploy log https://app.netlify.com/sites/cyf-ufd/deploys/670edb7e93f802000825b3df
😎 Deploy Preview https://deploy-preview-218--cyf-ufd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HamzatKazeem HamzatKazeem self-assigned this Oct 14, 2024
@HamzatKazeem HamzatKazeem added the Needs Review Participant to add when requesting review label Oct 14, 2024
islam95
islam95 suggested changes Oct 14, 2024
View reviewed changes
Copy link
Member

@islam95 islam95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @HamzatKazeem Well done. It's your second PR!
You page can be looked at https://deploy-preview-216--cyf-ufd.netlify.app/form-controls/

Have a look at https://pagespeed.web.dev/analysis/ and check your page analysis. Try to address issues with Accessibility. You should aim to 100% on that one for this task.

Form-Controls/index.html Show resolved Hide resolved
Form-Controls/index.html Outdated Show resolved Hide resolved
Form-Controls/index.html Outdated Show resolved Hide resolved
Form-Controls/index.html Outdated Show resolved Hide resolved
Form-Controls/index.html Outdated Show resolved Hide resolved
Form-Controls/styles.css Outdated Show resolved Hide resolved
Form-Controls/styles.css Outdated Show resolved Hide resolved
Form-Controls/styles.css Outdated Show resolved Hide resolved
Form-Controls/styles.css Outdated Show resolved Hide resolved
Form-Controls/styles.css Outdated Show resolved Hide resolved
@islam95 islam95 added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Oct 14, 2024
@HamzatKazeem
Fixing PR Feedback
c96d40b 
-fix width issues using max-width
-fixing typo errors
-fixing missing attributes within form elements
@HamzatKazeem
Copy link
Author

HamzatKazeem commented Oct 15, 2024 •
edited
Loading

@islam95 Thanks for taking the time to review my PR. I have fixed the suggestions as you suggested.
Looks like some mix-up occurred in providing the URL for the deployed work. 216 quoted here but my PR id is 218 and my lighthouse score for accessibility is 100%. Can I move this task to done now?

islam95
islam95 approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@islam95 islam95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @HamzatKazeem. You addressed my suggestions well.
You may now complete this PR.

Form-Controls/styles.css Outdated Show resolved Hide resolved
@HamzatKazeem
Copy link
Author

@islam95 Thank you for your time and feedback

@HamzatKazeem HamzatKazeem added the Complete Participant to add when work is complete and review comments have been addressed label Oct 15, 2024
@HamzatKazeem
Remove Extra CSS Selector
2bfbdc5 
Removing the extra CSS selector and replacing it with attribute gap to separate the buttons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islam95 islam95 islam95 approved these changes

@SallyMcGrath SallyMcGrath Awaiting requested review from SallyMcGrath

@shieldo shieldo Awaiting requested review from shieldo

At least 1 approving review is required to merge this pull request.

Assignees

@HamzatKazeem HamzatKazeem

Labels
Complete Participant to add when work is complete and review comments have been addressed Reviewed Volunteer to add when completing a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HamzatKazeem @islam95