Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

London | Samira Hekmati | Module Tools | Week 1 | Number Systems #20

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

samirahekmati
Copy link

@samirahekmati samirahekmati commented Feb 28, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@samirahekmati samirahekmati added the Needs Review Participant to add when requesting review label Feb 28, 2025
Copy link

@ehwus ehwus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one mistake (which may very well have been a typo) this work demonstrates a really good understanding of the first chapter of the book and both binary and hex number systems and how these can be used to represent chars / colours. Great work!


What is 10101 + 01010?
Answer:
Answer: 110111
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Be sure to double check your columns here:

| 1 | 0 | 1 | 0 | 1 | +
| 0 | 1 | 0 | 1 | 0 |
----------------
| 1 | 1 | 1 | 1 | 1 |

Copy link
Author

@samirahekmati samirahekmati Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Alex, for catching that mistake! I fixed it.

@ehwus ehwus added Complete Volunteer to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review labels Mar 2, 2025
@mjpeet mjpeet added the 📅 Sprint 1 Assigned during Sprint 1 of this module label Mar 2, 2025
@samirahekmati samirahekmati changed the title London | Samira Hekmati | Module Tools | Sprint 1 | Number Systems London | Samira Hekmati | Module Tools | Week 1 | Number Systems Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and review comments have been addressed 📅 Sprint 1 Assigned during Sprint 1 of this module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants