Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

London | Elhadj Abdoul Diallo | Module-Tools | WEEK1- Number-systems #17

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

eediallo
Copy link

@eediallo eediallo commented Feb 28, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

[Elhadj Abdoul Diallo] added 21 commits February 26, 2025 16:15
@eediallo eediallo added the Needs Review Participant to add when requesting review label Feb 28, 2025
Copy link

@ehwus ehwus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very thoughtful response to the assignment, and I particularly enjoyed getting to see your working throughout. You've shown a very good understanding of the course material this week, and with binary and hex numbers and their practical applications. Really good work!

@@ -5,61 +5,66 @@ Do not convert any binary numbers to decimal when solving a question unless the
The goal of these exercises is for you to gain an intuition for binary numbers. Using tools to solve the problems defeats the point.

Convert the decimal number 14 to binary.
Answer:
Answer: 1110
![answer-1](14-decimal-binary.png)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: It is a real pleasure to see you include your working here, you've employed a very reliable method for working these out consistently!


Convert the decimal number 386 to hex.
Answer:
Answer: 182
![alt text](386-to-hex.png)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: I've never done this manually so it's really useful to see this method illustrated!


Convert the decimal number 386 to hex.
Answer:
Answer: 182
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: One of the problems with hex numbers are that they often look like decimal ones, so we can avoid this ambiguity here by using 0x182

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, thank you for bringing this up. I am going to update it.

@ehwus ehwus added Complete Volunteer to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review labels Mar 2, 2025
@eediallo
Copy link
Author

eediallo commented Mar 2, 2025

@ehwus Thank you for reviewing my work! I really appreciate it.

@mjpeet mjpeet added the 📅 Sprint 1 Assigned during Sprint 1 of this module label Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Volunteer to add when work is complete and review comments have been addressed 📅 Sprint 1 Assigned during Sprint 1 of this module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants