West Midlands | MAY | EMIN AKTURK | Sprint 2 | MODULE-STRUCTURING-AND-TESTING-DATA #691
Conversation
…e professional one.
eminakturk
added
the
Needs Review
MattGoodwin0
added
Review in progress
|
It looks like the two new PRs still has the Sprint 1 files - let me know if you want to jump on a call to run through the GIT side |
|
I have sent a DM on slack. |
eminakturk
changed the title
Sprint-2/1-key-errors/0.js
Outdated
| // =============> write your new code here | ||
|
|
||
| function capitalise(str) { | ||
| let capitalisedStr = `${str[0].toUpperCase()}${str.slice(1)}`; |
There was a problem hiding this comment.
This is good! I'll won't pull it as a review comment as the template code declared the variable with let. However, if you are not re-assigning a variable we should be using const.
Sprint-2/2-mandatory-debug/1.js
Outdated
| return a + b; | ||
| } | ||
|
|
||
| console.log(`The sum of 45 and 12 is ${sum(45, 12)}`); // Output: "The sum of 10 and 32 is 42" |
There was a problem hiding this comment.
Is this the output returned by the function?
| return `${pounds}.${pence}`; | ||
| } | ||
|
|
||
| console.log(`The amount in pounds is ${toPounds("10000000")}`); |
There was a problem hiding this comment.
What does this output?
Just be careful with formatting too - is there anything that could be improved?
|
|
||
| // c) What is the return value of pad is called for the first time? | ||
| // =============> write your answer here | ||
| // =============> would be 00. | ||
|
|
||
| // d) What is the value assigned to num when pad is called for the last time in this program? Explain your answer | ||
| // =============> write your answer here |
MattGoodwin0
added
Reviewed
eminakturk
added
the
Needs Review
|
Your PR's title didn't contain a known region. Please check the expected title format, and make sure your region is in the correct place and spelled correctly. |
…odule-Structuring-and-Testing-Data into coursework/sprint-2
eminakturk
changed the title
eminakturk
changed the title
|
Your PR's title didn't contain a known region. Please check the expected title format, and make sure your region is in the correct place and spelled correctly. |
1 similar comment
|
Your PR's title didn't contain a known region. Please check the expected title format, and make sure your region is in the correct place and spelled correctly. |
eminakturk
changed the title
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (MODULE-STRUCTURING-AND-TESTING-DATA) doesn't match expected format (example: 'Sprint 2', without quotes) |
eminakturk
changed the title
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (MODULE-STRUCTURING-AND-TESTING-DATA) doesn't match expected format (example: 'Sprint 2', without quotes) |
eminakturk
changed the title
|
Your PR's title didn't contain a known region. Please check the expected title format, and make sure your region is in the correct place and spelled correctly. |
eminakturk
changed the title
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s |
eminakturk
changed the title
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Sprint part (MODULE-STRUCTURING-AND-TESTING-DATA) doesn't match expected format (example: 'Sprint 2', without quotes) |
eminakturk
changed the title
MattGoodwin0
added
Complete
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.