Skip to content

ITP_JAN_25 | HASAN DEMIROZ | Module-Structuring-and-Testing-Data | Sprint 3 #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

ITP_JAN_25 | HASAN DEMIROZ | Module-Structuring-and-Testing-Data | Sprint 3 #424

wants to merge 15 commits into from

Conversation

hasandemiroz
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

HappyCoder5114
HappyCoder5114 reviewed Mar 25, 2025
View reviewed changes
Copy link

@HappyCoder5114 HappyCoder5114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see the comments.

@cjyuan cjyuan changed the base branch from coursework/sprint-3 to main March 27, 2025 19:50
@cjyuan cjyuan added the Reviewed Volunteer to add when completing a review label Mar 27, 2025
@hasandemiroz hasandemiroz added Needs Review Participant to add when requesting review and removed Reviewed Volunteer to add when completing a review labels Apr 2, 2025
@HappyCoder5114
Copy link

hey this looks okay,could be merged now. but i dont have write access still. could anyone who who write access preceed this to completed ?

@hasandemiroz hasandemiroz added Complete Participant to add when work is complete and review comments have been addressed and removed Needs Review Participant to add when requesting review labels Apr 16, 2025
@hasandemiroz
Copy link
Author

hey this looks okay,could be merged now. but i dont have write access still. could anyone who who write access preceed this to completed ?

Thank you for your review. I have updated the label as complete now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HappyCoder5114 HappyCoder5114 HappyCoder5114 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Complete Participant to add when work is complete and review comments have been addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hasandemiroz @HappyCoder5114 @cjyuan