This repository was archived by the owner on Apr 18, 2025. It is now read-only.
generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 54
Feature/wireframeMGC1 | PRISCILLA MAC-GATUS | HTML-CSS| WEEK1 #194
Open
Priscilla-MacGatus
wants to merge
44
commits into
CodeYourFuture:main
Choose a base branch
from
Priscilla-MacGatus:feature/wireframe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/wireframeMGC1 | PRISCILLA MAC-GATUS | HTML-CSS| WEEK1 #194
Priscilla-MacGatus
wants to merge
44
commits into
CodeYourFuture:main
from
Priscilla-MacGatus:feature/wireframe
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gs for the first content in article tags
…as the second content of article.
…n tags for the third content of the article tag
…he article section in css
…nt in the div tag
…) in second article. and applied a comment and css border style
…argin style to 3rd article
…rt, added colors, fonts, shadows and padding.
…e an description.
✅ Deploy Preview for cyf-module-html-css ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete the task list below this message.
If your PR is rejected, check the task list.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
The webpage has a consistent color scheme for links and text.
Semantic HTML tags are used to structure the webpage.
The page header includes a title and description.
The articles section has three articles, each including a title, summary, and a link with the button.
The page footer is fixed to the bottom of the viewport.
The first article is styled using the:first-child pseudo-class.
The webpage is styled using a linked .css file applying various font styles, alignment, and positioning properties
The webpage is properly committed and pushed to a branch on GitHub.
Questions
Ask any questions you have for your reviewer.
Do the sections flow well visually and logically?
Does the CSS follow best practices for maintainability?
Is the HTML structure clear and easy to follow?
Did you notice any visual or functional bugs?
Do you have any suggestions for improving the code readability or structure?