ITP_LONDON | PRISCILLA_EMEBO | Module-Data-Groups | Todo-list #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjyuan
reviewed
Apr 21, 2025
| checkIcon.style.cursor = "pointer"; | ||
| checkIcon.addEventListener("click", () => { | ||
| todo.completed = !todo.completed; | ||
| li.style.textDecoration = todo.completed ? "line-through" : "none"; |
There was a problem hiding this comment.
We could just call populateTodoList() to update the view (to avoid maintaining two sets of code to change view).
| trashIcon.className = "fa fa-trash ms-2"; | ||
| trashIcon.style.cursor = "pointer"; | ||
| trashIcon.addEventListener("click", () => { | ||
| todos.splice(todos.indexOf(todo), 1); |
There was a problem hiding this comment.
For better performance (i.e., without the need to search for todo in the array), we could make available the index of the current todo at line 11 as
todos.forEach((todo, index) => {
cjyuan
added
Reviewed
|
On separate note, it is a good practice to give a brief description to every PR.
|
|
Thank you very much. I'll make the necessary changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.