Skip to content

IPT JAN 25 | Katarzyna Kazimierczuk | Data Groups | Sprint 3 - quote qenerator #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

IPT JAN 25 | Katarzyna Kazimierczuk | Data Groups | Sprint 3 - quote qenerator #504

wants to merge 1 commit into from

Conversation

katarzynakaz
Copy link

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Quote generator done.

Questions

No questions.

@katarzynakaz katarzynakaz added the Needs Review Participant to add when requesting review label Apr 19, 2025
shieldo
shieldo reviewed Apr 20, 2025
View reviewed changes
Copy link

@shieldo shieldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The web page itself does work, so well done! The tests however don't pass, and I don't know if that's because the tests are out of date or whether there is something that doesn't work. Failing tests are never something to ignore, though :)

@shieldo shieldo added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shieldo shieldo shieldo left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Reviewed Volunteer to add when completing a review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katarzynakaz @shieldo