ITP_GLASGOW_APR | HANNA_MYKYTIUK | MODULE__DATA_\GROUPS | SPRINT_2

Sprint-1/implement/max.test.js

@@ -12,6 +12,16 @@ We have set things up already so that this file can see your function from the o
 
 const findMax = require("./max.js");
 
+describe("findMax", () => {
+    [
+        { input: [], expected: ['a','b','c'] },
+        { input: [5, 1, 1, 2, 3, 2, 5, 8], expected: [5, 1, 2, 3, 8] },
+        { input: [1, 2, 1], expected: [1, 2] },
+    ].forEach(({ input, expected }) =>
+        it(`deduplicated array for [${input}]`, () => expect(findMax(input)).toEqual(expected))
+    );
+});
+
 // Given an empty array
 // When passed to the max function
 // Then it should return -Infinity

Sprint-2/debug/address.js

@@ -12,4 +12,4 @@ const address = {
   postcode: "XYZ 123",
 };
 
-console.log(`My house number is ${address[0]}`);
+console.log(`My house number is ${address.houseNumber}`);

Sprint-2/debug/author.js

@@ -11,6 +11,7 @@ const author = {
   alive: true,
 };
 
-for (const value of author) {
-  console.log(value);
+for (const key in author) {
+  console.log(key, author[key]);
 }
+

Sprint-2/debug/recipe.js

@@ -11,5 +11,7 @@ const recipe = {
 };
 
 console.log(`${recipe.title} serves ${recipe.serves}
-  ingredients:
-${recipe}`);
+  ingredients: `);
+  for (let i=0; i<recipe.ingredients.length; i++){
+    console.log(recipe.ingredients[i]);
+  }

Sprint-2/implement/contains.js

@@ -1,3 +1,11 @@
-function contains() {}
+function contains(obj, property) { 
+    try {
+        return Object.hasOwn(obj, property);
+    }
+    catch(e ){
+        console.log(e);
+        return false;
+    } 
+}
 
 module.exports = contains;

Sprint-2/implement/contains.test.js

@@ -13,23 +13,39 @@ as the object doesn't contains a key of 'c'
 
 // Acceptance criteria:
 
-// Given a contains function
-// When passed an object and a property name
-// Then it should return true if the object contains the property, false otherwise
+describe("contains", () => {
+    // Given a contains function
+    // When passed an object and a property name
+    // Then it should return true if the object contains the property, false otherwise
+    it("check if object has property", () => {
+      expect(contains({name: 'Hanna'}, 'name')).toEqual(true);
+      expect(contains({name: 'Hanna'}, 'surname')).toEqual(false);
+    });
+    // Given an empty object
+    // When passed to contains
+    // Then it should return false
+    it("if object is empty it should return false", () => {
+      expect(contains({}, 'name')).toEqual(false);
+    });
+    // Given an object with properties
+    // When passed to contains with an existing property name
+    // Then it should return true
+    it("if object has multiple properties and passed existing property name it should return true", () => {
+      expect(contains({property1: 'exist1', property2: 'exist2'}, 'property1')).toEqual(true);
+    });
+    // Given an object with properties
+    // When passed to contains with a non-existent property name
+    // Then it should return false
+    it("if object has multiple properties and passed non-existing property name it should return false", () => {
+      expect(contains({property1: 'exist1', property2: 'exist2'}, 'property3')).toEqual(false);
+    });
+    // Given invalid parameters like an array
+    // When passed to contains
+    // Then it should return false or throw an error
+    it("in case of invalid parametr function contains should throw an error", () => {
+      expect(contains( [1,2,3], 'property')).toEqual(false);
+      expect(contains( "test", 'property')).toEqual(false);
+    });
+});
 
-// Given an empty object
-// When passed to contains
-// Then it should return false
-test.todo("contains on empty object returns false");
 
-// Given an object with properties
-// When passed to contains with an existing property name
-// Then it should return true
-
-// Given an object with properties
-// When passed to contains with a non-existent property name
-// Then it should return false
-
-// Given invalid parameters like an array
-// When passed to contains
-// Then it should return false or throw an error

Sprint-2/implement/lookup.js

@@ -1,5 +1,10 @@
-function createLookup() {
-  // implementation here
+function createLookup(complexArray) {
+  let object ={};
+  for (let i=0; i<complexArray.length; i++){
+    object[complexArray[i][0]] = complexArray[i][1];
+  }
+  return object;
+
 }
 
 module.exports = createLookup;

Sprint-2/implement/lookup.test.js

@@ -1,6 +1,8 @@
 const createLookup = require("./lookup.js");
 
-test.todo("creates a country currency code lookup for multiple codes");
+it("function recieve array of country code and currency code pairs should return an appropriate object", () => {
+  expect(createLookup([['US', 'USD'], ['CA', 'CAD']])).toEqual({'US': 'USD', 'CA': 'CAD'});
+});
 
 /*
 

Sprint-2/implement/querystring.js

@@ -6,11 +6,19 @@ function parseQueryString(queryString) {
   const keyValuePairs = queryString.split("&");
 
   for (const pair of keyValuePairs) {
-    const [key, value] = pair.split("=");
-    queryParams[key] = value;
+    //console.log(pair.split("="));
+    const array = pair.split("=");
+    let value = '';
+    for(let i = 1; i<array.length; i++){
+      value += array[i];
+      if (i != array.length - 1){
+        value += '=';
+      }
+    }
+    queryParams[array[0]] = value;
   }
-
   return queryParams;
 }
+console.log(parseQueryString("equation=x=y+1"));
 
 module.exports = parseQueryString;

Sprint-2/implement/querystring.test.js

@@ -10,3 +10,10 @@ test("parses querystring values containing =", () => {
     "equation": "x=y+1",
   });
 });
+
+test("parses querystring values containing = and &", () => {
+  expect(parseQueryString("equation=x=y+1&something=something")).toEqual({
+    "equation": "x=y+1",
+    "something": "something"
+  });
+});

Sprint-2/implement/tally.js

@@ -1,3 +1,31 @@
-function tally() {}
+function tally(array) {
+    try {
+        if (typeof(array) == 'string'){
+            console.log('String is invalid input');
+            return false;
+        }
+        let copy = [];
+        for (let i=0; i<array.length; i++){
+            if (copy.indexOf(array[i]) === -1) {
+                copy.push(array[i]);
+            }       
+        }
+        let object = {};
+        for (let i=0; i < copy.length; i++){
+            let count = 0;
+            for (let j=0; j < array.length; j++){
+                if (array[j] == copy[i]){
+                    count = count + 1;
+                }
+            }
+            object[copy[i]] = count;
+        }
+        return object;
+    } catch(e){
+        console.log(e);
+        return false;
+    }
+
+}
 
 module.exports = tally;

Sprint-2/implement/tally.test.js

@@ -19,16 +19,30 @@ const tally = require("./tally.js");
 // Given a function called tally
 // When passed an array of items
 // Then it should return an object containing the count for each unique item
+it("it should return an object containing the count for each unique item", () => {
+    expect(tally(['a'])).toEqual({ a: 1 });
+    expect(tally(['a', 'a', 'a'])).toEqual({ a: 3});
+    expect(tally(['a', 'a', 'b', 'c'])).toEqual({ a : 2, b: 1, c: 1 });
+});
 
 // Given an empty array
 // When passed to tally
 // Then it should return an empty object
-test.todo("tally on an empty array returns an empty object");
+it("empty array should return an empty object", () => {
+    expect(tally(['a'])).toEqual({ a: 1 });
+});
 
 // Given an array with duplicate items
 // When passed to tally
 // Then it should return counts for each unique item
+it("array with duplicate items should return an object containing the count for each unique item", () => {
+    expect(tally(['a', 'a', 'b', 'b', 'c', 'c'])).toEqual({ a : 2, b: 2, c: 2 });
+});
+
 
 // Given an invalid input like a string
 // When passed to tally
 // Then it should throw an error
+it("Given an invalid input it should throw an error", () => {
+    expect(tally('string')).toEqual(false);
+});

Sprint-2/interpret/invert.js

@@ -10,20 +10,27 @@ function invert(obj) {
   const invertedObj = {};
 
   for (const [key, value] of Object.entries(obj)) {
-    invertedObj.key = value;
+    invertedObj[value] = key;
+    //invertedObj.key = value;
   }
-
   return invertedObj;
 }
 
+module.exports = invert;
+
 // a) What is the current return value when invert is called with { a : 1 }
+//current return value is: { key: 1 }
 
 // b) What is the current return value when invert is called with { a: 1, b: 2 }
+// current return value is: { key: 2 }
 
 // c) What is the target return value when invert is called with {a : 1, b: 2}
+// target output value is: { '1': 'a', '2': 'b' }
 
 // c) What does Object.entries return? Why is it needed in this program?
+// It returns an array of key/values of object. It is needed because in order to invert key and values we have to know them.
 
 // d) Explain why the current return value is different from the target output
+// because .key create one object paramenter with name 'key' and assign to it value(each of values shoud be a key)
 
 // e) Fix the implementation of invert (and write tests to prove it's fixed!)

Sprint-2/interpret/invert.test.js

@@ -0,0 +1,6 @@
+const invert = require("./invert.js");
+
+it("it should return an object with reverce key and values", () => {
+    expect(invert({ a : 1 })).toEqual({ '1': 'a' });
+    expect(invert({ a: 1, b: 2 })).toEqual({ '1': 'a', '2': 'b' });
+});