Add logic for error handling #124
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandkumarpatel
requested changes
Apr 12, 2017
| @@ -35,8 +35,9 @@ DockAttach.task = (job) => { | |||
| if (err.getCurrentASG() === targetASGName) { | |||
| throw new WorkerStopError('instance already attached to asg', { err, targetASGName }) | |||
| } | |||
|
|
|||
| throw err | |||
| if (!(new RegExp('is already part of AutoScalingGroup:' + process.env.DOCK_POOL_ASG_NAME).test(err.data.originalError.message))) { | |||
There was a problem hiding this comment.
so we still need this worker to retry. if you do this then the worker will stop and not retry. Was you want to happen here is set err.level = debug
OR make a new error class called ignoreable or something and inherit form baseError
new BaseError('message', {}, {
level: 'critical', // the reporting level
fingerprint: 'mygroup' // a grouping fingerprint
})
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove the common 'already part of AutoScalingGroup:delta-asg-dock-pool' error that happens when shiva attempts to attach a dock to an org's asg that has not been detached from the dock pool fast enough