Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create requirements.txt #40

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Create requirements.txt #40

wants to merge 2 commits into from
+3 −0

Conversation

Brzozova
Copy link

@Brzozova Brzozova commented Oct 5, 2018

No description provided.

Rafalkufel
Rafalkufel requested changes Oct 6, 2018
View reviewed changes
Copy link
Contributor

@Rafalkufel Rafalkufel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be rather python-docx== 0.8.7. Not python-docs-theme==2018.7

BTW I noticed that a new release came up in august this year.

magul
magul requested changes Oct 6, 2018
View reviewed changes
Copy link
Member

@magul magul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be changed and use requirements.txt to install requirements.

More, in f87161f @Rafalkufel introduced tests and nose package. As it's only development tool it should be added to newly created dev-requirements.txt and also installed on AppVeyorusingpip install -r dev-requirements.txt`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magul magul magul requested changes

@Rafalkufel Rafalkufel Rafalkufel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Brzozova @magul @Rafalkufel