-
Notifications
You must be signed in to change notification settings - Fork 8
Don't use QSqlDatabase #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rafalkufel
requested changes
Apr 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done!
Only couple of comments to improve readability
...ntainers/main_body/content/settings/settings_tabs/team_member_tab/team_member_table_group.py
Outdated
Show resolved
Hide resolved
...ntainers/main_body/content/settings/settings_tabs/team_member_tab/team_member_table_group.py
Outdated
Show resolved
Hide resolved
...ntainers/main_body/content/settings/settings_tabs/team_member_tab/team_member_table_group.py
Outdated
Show resolved
Hide resolved
...ntainers/main_body/content/settings/settings_tabs/team_member_tab/team_member_table_group.py
Outdated
Show resolved
Hide resolved
...ntainers/main_body/content/settings/settings_tabs/team_member_tab/team_member_table_group.py
Outdated
Show resolved
Hide resolved
...ntainers/main_body/content/settings/settings_tabs/team_member_tab/team_member_table_group.py
Outdated
Show resolved
Hide resolved
...ntainers/main_body/content/settings/settings_tabs/team_member_tab/team_member_table_group.py
Outdated
Show resolved
Hide resolved
...ntainers/main_body/content/settings/settings_tabs/team_member_tab/team_member_table_group.py
Outdated
Show resolved
Hide resolved
...ntainers/main_body/content/settings/settings_tabs/team_member_tab/team_member_table_group.py
Outdated
Show resolved
Hide resolved
6bc2122
to
ad0d4a2
Compare
This is a proof of concept approach to Table view of team members. We also need rethink how to approach that table business-wise (e.g. I don't know if we allow to delete team members, that are listed in documents?)
ad0d4a2
to
af61f20
Compare
Rafalkufel
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept approach to Table view of team members. We also need rethink how to approach that table business-wise (e.g. I don't know if we allow to delete team members, that are listed in documents?)
Closes #40
Closes #34 (as we don't use QSqlDatabase anymore)