Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azbl/665 Make Before and After Text on Image Actual Text #906

Conversation

AZBL
Copy link
Contributor

@AZBL AZBL commented Sep 23, 2024

This addresses issue #665 and builds off previous PR #721 (which was closed after inactivity).

  1. Replaces beforeAfter.png that included "Before" and "After" as part of the image to one that doesn't include this.
  2. Compressed the image reducing size by 72%.
  3. Added aria-labelledby to the Image component.
  4. Added caption: "A Philadelphia lot before a clean up and the same lot, filled with trees and greenery after a clean up." in a p tag.
  5. Ensured no large gap between caption and image by removing gap on container div.
  6. Made caption text regular font weight (was bold).

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vacant-lots-proj ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 4:55pm

@AZBL
Copy link
Contributor Author

AZBL commented Sep 23, 2024

Copy link
Collaborator

@CodeWritingCow CodeWritingCow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AZBL, updated image and caption look good on mobile and desktop. Thanks!

Desktop

Screen Shot 2024-09-23 at 11 59 30 PM

Mobile

Screen Shot 2024-09-23 at 11 59 55 PM

@CodeWritingCow
Copy link
Collaborator

@AZBL The compressed image looks the same as the original image, yet its file size is much smaller. That's awesome! What tool did you use for the image compression?

@AZBL
Copy link
Contributor Author

AZBL commented Sep 24, 2024

@AZBL The compressed image looks the same as the original image, yet its file size is much smaller. That's awesome! What tool did you use for the image compression?

@CodeWritingCow I used tinypng.com to compress it. I actually did it originally because I kept getting this error when I tried to push,

error: RPC failed; HTTP 400 curl 22 The requested URL returned error: 400
send-pack: unexpected disconnect while reading sideband packet

but compressing it still didn't work, so I entered

git config http.postBuffer 524288000

and pushed again and it worked.

@CodeWritingCow CodeWritingCow merged commit b8e0886 into CodeForPhilly:staging Sep 25, 2024
5 checks passed
@CodeWritingCow CodeWritingCow added the A11y Accessibility label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y Accessibility frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants