Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zheyichn/746 rake icon contrast fix #750

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Zheyichn/746 rake icon contrast fix #750

merged 3 commits into from
Jul 18, 2024

Conversation

zheyichn
Copy link
Contributor

@zheyichn zheyichn commented Jul 15, 2024 •
edited
Loading

Solution

  • Modified Rake icon component to make it more visible (color : white) in WHCM.
  • Applied inline styling within the component to achieve the goal, as the styling of rake-icon is not used by anywhere else.

Screenshots:

Dark Mode

WHCM-rake

Light Mode:

light-mode

Closes #746

@vercel Vercel
Copy link

vercel bot commented Jul 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vacant-lots-proj ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 6:10pm

@zheyichn
Copy link
Contributor Author

Hi @CodeWritingCow, pls review when you get a second. Thank you.

@CodeWritingCow CodeWritingCow added the A11y Accessibility label Jul 16, 2024
bacitracin
bacitracin approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@bacitracin bacitracin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How funny that this Rake component is the only one on its own that we couldn't get from React icons Pi

@CodeWritingCow CodeWritingCow merged commit 05157d9 into CodeForPhilly:staging Jul 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bacitracin bacitracin bacitracin approved these changes

@CodeWritingCow CodeWritingCow CodeWritingCow approved these changes

Assignees
No one assigned
Labels
A11y Accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zheyichn @bacitracin @CodeWritingCow