Michael dratch/712 error message if map fails to load #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodeWritingCow
requested changes
Jul 7, 2024
There was a problem hiding this comment.
Hi @Michael-Dratch I tested your PR. The error message appears correctly if the map API call fails. Once you make the changes mentioned in my comments, I'll approve and merge your PR. Thanks!
|
Hi @CodeWritingCow, thanks for the feedback. I just made those requested updates and pushed the changes. |
CodeWritingCow
approved these changes
Jul 7, 2024
There was a problem hiding this comment.
@Michael-Dratch updated PR looks good. Thanks for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for this task: Show error message if map fails to load #712
#712
To view the error state go to the find properties page, open dev tools, and block the URL from google storage to simulate a failed API call.
On page reload, this error message will be displayed on the property details panel.
I think the automatic prettier formatting makes it seem like a lot of lines of code have been changed. But most of these lines are minor changes in formatting. If it would be better for the PR I can redo do these changes with out any of the formatting changes and resubmit.