Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

619: Change tailwind config and add new contrast friendly blue #722

Merged

Conversation

JT0Y
Copy link

@JT0Y JT0Y commented Jul 1, 2024

Issue #619

old pr: #713

Make blue links darker to pass contrast color ratio. Adds new dark blue color and swap out all blue links to use new 900 blue.

Copy link
Collaborator

@CodeWritingCow CodeWritingCow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JT0Y, I tested your PR with the color contrast tool mentioned in your original PR description. The new blue color passes contrast tests for three background colors common to this project. Thanks for taking care of this.

Screen Shot 2024-07-05 at 2 21 25 PM Screen Shot 2024-07-05 at 2 25 33 PM Screen Shot 2024-07-05 at 2 30 43 PM

@CodeWritingCow
Copy link
Collaborator

CodeWritingCow commented Jul 5, 2024

@bacitracin or @marvieqa when you get a chance, can you review this a11y PR? Thanks!

@CodeWritingCow CodeWritingCow added the A11y Accessibility label Jul 5, 2024
Copy link
Collaborator

@bacitracin bacitracin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeWritingCow CodeWritingCow merged commit dbfd341 into CodeForPhilly:staging Jul 6, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y Accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants