Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 700: Add custom 404 page #711

Merged

Conversation

AZBL
Copy link
Contributor

@AZBL AZBL commented Jun 25, 2024

This adds a custom 404 page.
It adds not-found.tsx to src/app/.
The navbar will still be present.
It has a return to home link.
It should work for any incorrect url.

clean and green 404

Addresses ticket #700

Copy link

vercel bot commented Jun 25, 2024

@AZBL is attempting to deploy a commit to the Clean and Green Philly Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@CodeWritingCow CodeWritingCow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @AZBL I tested the PR locally. Custom 404 page appears for wrong URLs. Header is also present. Thanks Alex!

@CodeWritingCow CodeWritingCow changed the title Added custom 404 page / addresses ticket 700 Issue 700: Add custom 404 page Jun 25, 2024
@CodeWritingCow CodeWritingCow merged commit 882bef0 into CodeForPhilly:staging Jun 25, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants