Lebovits/fix backend issues #708

nlebovits · 2024-06-24T20:24:14Z

No description provided.

vercel · 2024-06-24T20:24:18Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
vacant-lots-proj	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 18, 2024 7:23am

zigouras · 2024-06-25T01:29:03Z

@nlebovits it looks like you pushed a new Pipfile and Pipefile.lock into the data/ dir. Our normal files are in data/src and should remain unchanged. I think you can remove those files.

zigouras · 2024-06-26T20:14:03Z

docs/SETUP/BACK_END.md

Some of these instructions are inaccurate and a repetition of what is in the rest of the document. I don't think the document is long enough to begin with to need a 'TLDR' section. Maybe you could use ChatGPT to generate a summary of this file, but as this new section stands now, I don't find it too useful.

HI @zigouras, can you point out which instructions might be inaccurate in this PR?

docs/SETUP/BACK_END.md

zigouras · 2024-07-17T16:47:11Z

docs/SETUP/BACK_END.md

-#### PostgreSQL
+```sh
+POSTGRES_PASSWORD=a-strong-password-here
+VACANT_LOTS_DB=postgresql://postgres:${POSTGRES_PASSWORD}@localhost/vacantlotdb


should be this for new port, see latest doc in staging
VACANT_LOTS_DB=postgresql://postgres:${POSTGRES_PASSWORD}@localhost:5433/vacantlotdb

zigouras · 2024-07-17T16:48:43Z

docs/SETUP/BACK_END.md

+
+```sh
+POSTGRES_PASSWORD=a-strong-password-here
+VACANT_LOTS_DB=postgresql://postgres:${POSTGRES_PASSWORD}@localhost/vacantlotdb


add port here too

zigouras

@nissim I think this looks good except you need to add the new port 5433 to the example postgres urls, see my comments.

zigouras · 2024-07-17T16:51:57Z

docs/SETUP/BACK_END.md


-For Mac and Linux, you can permanently store the environmental variables in your command line shell's configuration file, e.g. `~/.bashrc`, `~/.bash_profile`, `~/.zshrc` or `~/.profile`.  Add a line `export VAR_NAME=VALUE` in your file and run `source file` to read it in when newly created.  Any new shells will automatically have the new environment.


This section should be left in. It is convenient to have shell variables for some users.

zigouras · 2024-07-17T16:52:15Z

docs/SETUP/BACK_END.md


-For Windows, you can set environmental variables under System -> Advanced or you can download a terminal emulator such as [Git Bash](https://gitforwindows.org/) and follow the instructions for Mac and Linux above.  A terminal emulator is reccommended.


keep this section.

zigouras · 2024-07-17T16:52:23Z

docs/SETUP/BACK_END.md


-All of your local environmental variables will be passed through to docker-compose so if you have them locally you should not have to hard-code them as indicated below.


keep this section.

zigouras · 2024-07-17T16:57:33Z

docs/SETUP/BACK_END.md


 The python script loads the tiles to Google Cloud as `vacant_properties_tiles_staging.pmtiles`. You can check this tileset by changing the config setting on the frontend `useStagingTiles` to `true`. If the tiles look OK, manually change the name in Google Cloud to remove the `_staging` and archive the previous copy.

 #### Google Streetview

 To update streetview images, after running the full data script run:

-```
+```sh
 docker-compose run streetview


Let's change all mentions of docker-compose to docker compose since the former has been deprecated.

zigouras · 2024-07-17T17:03:13Z

docs/SETUP/BACK_END.md

+2. When this has finished, also run:
+
+   ```sh
+   docker-compose build postgres


docker compose build should build all the containers, including postgres but I understand your experience was different so I guess we can leave this in.

zigouras · 2024-07-17T17:03:56Z

docs/SETUP/BACK_END.md

+
+1. The first time you set up your backend, or any time either of the two Docker files change, build the Docker services by running:
+
+   ```sh


Good use of sh formatting so they get the convenience of the copy button.

zigouras · 2024-07-17T17:30:25Z

data/src/classes/diff_report.py

@@ -48,7 +48,7 @@ def __init__(self, timestamp_string: str = None):
        """
        self.diff_tables = self._list_diff_tables()
        self.timestamp_string = timestamp_string
-        self.report: str = "The back-end data has been fully refreshed.  Here is the diff report on " + len(self.diff_tables) + " key tables.\nLegend: table A = new data, table B = old data.\n\n"


You can remove this file. This change has already been included with another and merging will not be automatic.

CodeWritingCow · 2024-07-18T05:42:51Z

@nlebovits PR has merge conflicts with a couple files. Can you resolve them? Thanks!

* make rake icon white under drak mode * use default color theme * use ButtonText for street view icon * add dependabot yml to keep ghactions, npm. and pip dependencies up to date * get pr_checks_backend.yml working (#756) * Set up pr_checks_backend.yml to run black formatter * Also run flake8 linting * Check if main docker container builds correctly * Check if postgres container runs correctly * update vscode/settings.json to match formatting + linting * Lebovits/issu643 add frontend formatting check (#752) * add formatting + linting checks to front end workflows * have checks run on PRs to staging, not main * Lebovits/fix backend issues (#708) * Fix issue with pipfile creation in docker * Update + organize back end docs --------- Co-authored-by: klaus <[email protected]> Co-authored-by: Gary Pang <[email protected]>

* Merge staging to main (#760) * make rake icon white under drak mode * use default color theme * use ButtonText for street view icon * add dependabot yml to keep ghactions, npm. and pip dependencies up to date * get pr_checks_backend.yml working (#756) * Set up pr_checks_backend.yml to run black formatter * Also run flake8 linting * Check if main docker container builds correctly * Check if postgres container runs correctly * update vscode/settings.json to match formatting + linting * Lebovits/issu643 add frontend formatting check (#752) * add formatting + linting checks to front end workflows * have checks run on PRs to staging, not main * Lebovits/fix backend issues (#708) * Fix issue with pipfile creation in docker * Update + organize back end docs --------- Co-authored-by: klaus <[email protected]> Co-authored-by: Gary Pang <[email protected]> * Staging (#768) * make rake icon white under drak mode * use default color theme * use ButtonText for street view icon * add dependabot yml to keep ghactions, npm. and pip dependencies up to date * get pr_checks_backend.yml working (#756) * Set up pr_checks_backend.yml to run black formatter * Also run flake8 linting * Check if main docker container builds correctly * Check if postgres container runs correctly * update vscode/settings.json to match formatting + linting * Lebovits/issu643 add frontend formatting check (#752) * add formatting + linting checks to front end workflows * have checks run on PRs to staging, not main * Lebovits/fix backend issues (#708) * Fix issue with pipfile creation in docker * Update + organize back end docs --------- Co-authored-by: klaus <[email protected]> Co-authored-by: Gary Pang <[email protected]> * make rake icon white under drak mode * use default color theme --------- Co-authored-by: klaus <[email protected]> Co-authored-by: Gary Pang <[email protected]>

nlebovits added 3 commits June 24, 2024 21:53

fix Pipfile creation error

49cd2d3

fix pipfile update issue:

9573808

fix data-diff typo

a467058

vercel bot deployed to Preview June 24, 2024 20:24 View deployment

nlebovits added 2 commits June 25, 2024 11:15

update docs with tl;dr

99e9e4b

delete mistakenly added pipfile stuff

b84f1b3

vercel bot deployed to Preview June 25, 2024 09:21 View deployment

zigouras reviewed Jun 26, 2024

View reviewed changes

CodeWritingCow reviewed Jul 9, 2024

View reviewed changes

docs/SETUP/BACK_END.md Outdated Show resolved Hide resolved

clean up backend setup docs

180ee1c

vercel bot deployed to Preview July 16, 2024 18:38 View deployment

zigouras reviewed Jul 17, 2024

View reviewed changes

CodeWritingCow added documentation Improvements or additions to documentation backend merge conflict labels Jul 18, 2024

final small fixes to docs

dde8b27

vercel bot deployed to Preview July 18, 2024 07:09 View deployment

remove outdated changes to diff_report.py

4b7f3d2

vercel bot deployed to Preview July 18, 2024 07:11 View deployment

Resolved merge conflicts, removed changes to diff_report.py

e3bb51a

vercel bot deployed to Preview July 18, 2024 07:20 View deployment

slight change to container building instructions

4aa1c22

nlebovits merged commit 53eadf8 into staging Jul 18, 2024
2 of 3 checks passed

vercel bot deployed to Preview July 18, 2024 07:23 View deployment

nlebovits deleted the lebovits/fix-backend-issues branch July 18, 2024 07:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lebovits/fix backend issues #708

Lebovits/fix backend issues #708

nlebovits commented Jun 24, 2024

vercel bot commented Jun 24, 2024 •

edited

Loading

zigouras commented Jun 25, 2024

zigouras Jun 26, 2024

CodeWritingCow Jul 9, 2024

zigouras Jul 17, 2024

zigouras Jul 17, 2024

zigouras left a comment

zigouras Jul 17, 2024

zigouras Jul 17, 2024

zigouras Jul 17, 2024

zigouras Jul 17, 2024 •

edited

Loading

zigouras Jul 17, 2024

zigouras Jul 17, 2024

zigouras Jul 17, 2024

CodeWritingCow commented Jul 18, 2024


		For Mac and Linux, you can permanently store the environmental variables in your command line shell's configuration file, e.g. `~/.bashrc`, `~/.bash_profile`, `~/.zshrc` or `~/.profile`. Add a line `export VAR_NAME=VALUE` in your file and run `source file` to read it in when newly created. Any new shells will automatically have the new environment.


		For Windows, you can set environmental variables under System -> Advanced or you can download a terminal emulator such as [Git Bash](https://gitforwindows.org/) and follow the instructions for Mac and Linux above. A terminal emulator is reccommended.


		All of your local environmental variables will be passed through to docker-compose so if you have them locally you should not have to hard-code them as indicated below.


		1. The first time you set up your backend, or any time either of the two Docker files change, build the Docker services by running:

		```sh

Lebovits/fix backend issues #708

Lebovits/fix backend issues #708

Conversation

nlebovits commented Jun 24, 2024

vercel bot commented Jun 24, 2024 • edited Loading

zigouras commented Jun 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zigouras left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zigouras Jul 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CodeWritingCow commented Jul 18, 2024

vercel bot commented Jun 24, 2024 •

edited

Loading

zigouras Jul 17, 2024 •

edited

Loading