Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 659: Add aria label to ThemeButtonLink #692

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Issue 659: Add aria label to ThemeButtonLink #692

merged 4 commits into from
Jun 12, 2024

Conversation

KenMain5
Copy link
Contributor

@KenMain5 KenMain5 commented Jun 12, 2024 •
edited by CodeWritingCow
Loading

Acceptance Criteria

  • add <aria-label="Atlas, opens in a new tab"> on the Atlast link.

Acceptance Criteria Finished

  • add <aria-label="Atlas, opens in a new tab"> on the Atlast link.

Closes #659

@vercel Vercel
Copy link

vercel bot commented Jun 12, 2024

@KenMain5 is attempting to deploy a commit to the Clean and Green Philly Team on Vercel.

A member of the Team first needs to authorize it.

@CodeWritingCow CodeWritingCow changed the base branch from main to staging June 12, 2024 22:48
@CodeWritingCow
Copy link
Collaborator

CodeWritingCow commented Jun 12, 2024 •
edited
Loading

Hi @KenMain5, when we submit a PR, we normally target the staging branch. The main branch is for deploying the website to the production environment. I've changed the base branch for this PR to staging.

Also, I've updated the PR title to describe what the PR will do.

CodeWritingCow
CodeWritingCow approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@CodeWritingCow CodeWritingCow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KenMain5 PR looks good!

@CodeWritingCow CodeWritingCow changed the title Fix issue 659 659: Add aria label to ThemeButtonLink Jun 12, 2024
@CodeWritingCow CodeWritingCow changed the title 659: Add aria label to ThemeButtonLink Issue 659: Add aria label to ThemeButtonLink Jun 12, 2024
@CodeWritingCow CodeWritingCow merged commit 665126a into CodeForPhilly:staging Jun 12, 2024
1 of 2 checks passed
@KenMain5 KenMain5 deleted the fix-issue-659 branch June 13, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeWritingCow CodeWritingCow CodeWritingCow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Property Details: Atlas link should also say "opens in a new tab"
3 participants
@KenMain5 @CodeWritingCow @nlebovits