Azbl/588 improve social media thumbnail and title #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-social-media-thumbnail-and-title
|
@AZBL is attempting to deploy a commit to the Clean and Green Philly Team on Vercel. A member of the Team first needs to authorize it. |
| "The ultimate toolkit to help community groups clean and green vacant properties to reduce gun violence in Philadelphia."; | ||
| const siteUrl = new URL("https://staging.cleanandgreenphilly.org/"); | ||
|
|
||
| /* REPLACE WITH URL BELOW BEFORE PUSHING TO PRODUCTION |
There was a problem hiding this comment.
@AZBL thanks for pointing this out.
|
|
||
| //imageUrl and imageAlt included to allow different images to be used for different pages in the future if desired | ||
|
|
||
| export function generateMetadata({ |
There was a problem hiding this comment.
Good use of a reusable method. Helps keep the codebase tidy.
CodeWritingCow
requested changes
Jun 7, 2024
There was a problem hiding this comment.
@AZBL can you remove the //? comments from this PR?
As we discussed, let's change the URL from staging to prod before merging the PR. Thanks!
CodeWritingCow
approved these changes
Jun 9, 2024
There was a problem hiding this comment.
@AZBL changes look good. I checked the URLs for each page's social media metadata, and they're all correct. Thanks for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #588
Updates social media thumbnail, title, and description for the homepage and all other pages of the site. This naturally changes/improves the metadata for the site as well.
Screenshots of how it should look for both the homepage as well as an example of how it'll look for another page are below. For the different pages, the title it will be [Page Title] - Clean and Green Philly. For instance, Find Properties - Clean & Green Philly.
For the descriptions I used the sub-header when available, for other pages that didn't have them I used what I thought made sense. Please @thansidwell or @nlebovits let me know what you think for them (you can check them out it in the code as the description in each page's layout file).
Added thumbnail.png to the public directory.
Creates generateMetaData function in utilities/ which accepts the root metadata and opengraph data from app/layout.tsx as a parameter and can be used in various pages' layout.tsx to easily create that pages metadata.
If we decide to change the thumbnail image for different pages in the future it should be a simple change.
As discussed with @CodeWritingCow for now this uses the staging url, and it'll have to be changed to the production url eventually. I think it'd also make sense to test to make sure everything works smoothly by either messaging each other on various social medias or using a site like Social Share Preview (I couldn't really do that during development since the url was my local host).