Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Property List Controls - 594 #611

Merged

Conversation

AZBL
Copy link
Contributor

@AZBL AZBL commented Apr 29, 2024

This change fixes the styling of the property list controls on the Find Properties page.

  • It should now match prototype.
  • It removes the bottom border line.
  • Removes left padding from [number] properties in view from large screens so there should only be 24 px of padding now
  • Keeps left padding for [number] properties in view for small and medium screens so there is an extra 16px of space (otherwise when it switches to 1 property property img per row and the download/filter buttons change to icons only the alignment looks off). I included how this looks with the extra padding and without the extra padding.

With Extra Padding:
with_padding

Without Extra Padding:
without_padding

  • Removes right padding from the Download button so there should only be 24 px of padding now

Copy link

vercel bot commented Apr 29, 2024

@AZBL is attempting to deploy a commit to the Clean and Green Philly Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vacant-lots-proj ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 2:28pm

@thansidwell
Copy link
Collaborator

thansidwell commented Apr 30, 2024

Hey @AZBL. Just one little fix and then it's all good. The hover background of the property cards' top padding gets cut off. Dropping it down like 8px or so would fix it.

CleanShot 2024-04-30 at 00 09 35@2x

@AZBL
Copy link
Contributor Author

AZBL commented May 2, 2024

@thansidwell
I added 8 px of top margin to the div containing the Table so now the hover background does not get cut off.

Copy link
Collaborator

@thansidwell thansidwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. @AZBL said he fixed the small issue I found.

@nlebovits nlebovits merged commit 5704e21 into CodeForPhilly:staging May 2, 2024
1 of 2 checks passed
@AZBL AZBL mentioned this pull request May 29, 2024
@Moylena
Copy link
Collaborator

Moylena commented May 29, 2024

#594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants