Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #1019 fix-card-padding #1106

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from

Conversation

Smadden00
Copy link

I removed the padding around each of the individual property cards and added padding to the left and right of the parent container that is equal to the margin for each property card. Doing so makes the spaces around and between each property card the same and still takes up the same total space on the page.

Pull Request Title

Checklist:

Before submitting your PR, please confirm that you have done the following:

  • [ x] I have opened my PR against the staging branch, NOT against main
  • [ x] I've run the relevant formatting and linting tools listed in the setup docs
  • [ x] I have commented hard-to-understand areas in my code
  • [ x] I've reviewed any merge conflicts to make sure they are resolved
  • [ x] My changes generate no new warnings

Description

Please include a summary of the change or the feature being introduced. Include relevant motivation and context. If necessary, list any dependencies that are required for this change.

Related Issue(s)

This PR addresses issue #1019 Fix Card Padding

Type of change

  • [ x] Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Please describe and/or document how you verified your changes. If relevant, include details of the testing environment and the tests you ran to see how your change affects the code.

It's a simple change, so I reviewed the change effects with several different screen widths.

I removed the padding around each of the individual property cards and added padding to the left and right of the parent container that is equal to the margin for each property card. Doing so makes the spaces around and between each property card the same and still takes up the same total space on the page.
Copy link

vercel bot commented Feb 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vacant-lots-proj ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 11:35pm

@CodeWritingCow
Copy link
Collaborator

Hi @Smadden00 GitHub failed to deploy your PR to the Vercel preview environment. Can you undo the changes to package.json and package-lock.json? Thanks!

(cross-spawn has been causing problems and there is a ticket open to look into it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants