-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hides extra map elements #1060
Hides extra map elements #1060
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@CodeWritingCow can we get a PR review? |
'.maplibregl-ctrl-attrib-button' | ||
); | ||
if (attributionButton) { | ||
attributionButton.click(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DonovanAndrews300 TypeScript is throwing an error saying that click
doesn't exist on Element
Hi @DonovanAndrews300 I ran your PR's code locally on my computer, and the UI works as expected. The map scale is not shown, and the attribution is hidden on page load. Thanks! However, GitHub failed to deploy the PR to Vercel's preview environment. I suspect it's due to a minor TypeScript error. TS says The fix should be pretty easy. If we just annotate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @DonovanAndrews300 can you add a type annotation for attributionButton? I'll then approve and merge your PR. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DonovanAndrews300 PR looks good. Thanks!
Description
This PR removes the map scale on the bottom left of the property map and hides the map attribute on the bottom right of the map by default. Addresses (Issue#1022)
Steps to Test
Screenshots