Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Show error message if map fails to load #712

Closed
3 tasks done
CodeWritingCow opened this issue Jun 25, 2024 · 2 comments
Closed
3 tasks done

Task: Show error message if map fails to load #712

CodeWritingCow opened this issue Jun 25, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request frontend

Comments

@CodeWritingCow
Copy link
Collaborator

CodeWritingCow commented Jun 25, 2024

Describe the task

When the map fails to fetch a pmtiles file from Google Cloud, hide loading spinner and show an error message in src/components/PropertyMap.tsx

Currently, the map page shows the loading spinner spins endlessly with the message "Loading properties." This makes for a poor user experience.

Acceptance Criteria

  • Hide loading spinner
  • Show error message instead of "Loading properties"
  • Show error message saying, "We are having technical issues. Please try again later."

Additional context

  • This ticket is related to Hotfix: Vacant properties pmtiles missing #709. While working on that PR, I noticed that if the map page got a 404 error for the pmtiles file, it would get stuck on "Loading properties." The loader would spin endlessly.
  • Here's a screenshot of what that looks like to a user:
Screen Shot 2024-06-25 at 11 41 15 AM
@Michael-Dratch
Copy link
Contributor

Can I pick up this task?

@bacitracin
Copy link
Collaborator

@Michael-Dratch assigned!

@bacitracin bacitracin moved this from To Do to In Development in Clean & Green Philly Jul 6, 2024
@CodeWritingCow CodeWritingCow moved this from In Development to In Review in Clean & Green Philly Jul 6, 2024
@CodeWritingCow CodeWritingCow moved this from In Review to On Staging in Clean & Green Philly Jul 7, 2024
@CodeWritingCow CodeWritingCow moved this from On Staging to Live in Clean & Green Philly Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend
Projects
Archived in project
Development

No branches or pull requests

3 participants