Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Old Commons-ui section #1019

Merged
merged 16 commits into from
Jan 14, 2025
Merged

Remove Old Commons-ui section #1019

merged 16 commits into from
Jan 14, 2025

Conversation

kelvinkipruto
Copy link
Contributor

@kelvinkipruto kelvinkipruto commented Dec 14, 2024

Description

This PR remove Legacy common-ui dependency

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Screenshots

image
image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Sorry, something went wrong.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Signed-off-by: Kipruto <[email protected]>
Signed-off-by: Kipruto <[email protected]>
Signed-off-by: Kipruto <[email protected]>
@kelvinkipruto kelvinkipruto marked this pull request as ready for review January 9, 2025 15:09
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 ... haven't run it locally yet but code looks good.


No test for QuickLinks?

apps/climatemappedafrica/src/components/Footer/index.js Outdated Show resolved Hide resolved
apps/climatemappedafrica/src/components/Section/index.js Outdated Show resolved Hide resolved
packages/commons-ui-core/src/Copyright/Copyright.js Outdated Show resolved Hide resolved
packages/commons-ui-core/src/Copyright/Copyright.test.js Outdated Show resolved Hide resolved
packages/commons-ui-core/src/Copyright/Copyright.js Outdated Show resolved Hide resolved
packages/commons-ui-core/src/QuickLinks/QuickLinks.js Outdated Show resolved Hide resolved
packages/commons-ui-core/src/QuickLinks/QuickLinks.js Outdated Show resolved Hide resolved
packages/commons-ui-core/src/QuickLinks/QuickLinks.js Outdated Show resolved Hide resolved
Copy link
Contributor

@m453h m453h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally and it looks good, there is one minor issue regarding the legend, it does slightly overlap the map, It would be better if we add a bit of space between it and the map (perhaps increase the map height and / hero component height to match the changes)

Screenshot 2025-01-10 at 10 57 19

Signed-off-by: Kipruto <[email protected]>
Signed-off-by: Kipruto <[email protected]>
Signed-off-by: Kipruto <[email protected]>
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (provided tests are fixed).

@kilemensi kilemensi added the chore A task that needs to be done (neither enhancement or bug) label Jan 13, 2025
@kelvinkipruto kelvinkipruto added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit f94c2df Jan 14, 2025
5 of 6 checks passed
@kelvinkipruto kelvinkipruto deleted the ft/remove-legacy-commons-ui branch January 14, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A task that needs to be done (neither enhancement or bug)
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants