Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Scala grammar #39

Merged
merged 2 commits into from
May 3, 2023
Merged

Add Scala grammar #39

merged 2 commits into from
May 3, 2023

Conversation

bishabosha
Copy link
Contributor

@bishabosha bishabosha commented Apr 29, 2023 •
edited
Loading

Description

Follow the guide on adding a new language, for tree-sitter-scala

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screenshot_2023-04-30_at_01 44 14

To produce the screenshot I locally updated CodeEdit to depend on this branch of CodeEditTextView

@bishabosha
Copy link
Contributor Author

screenshot is now attached

thecoolwinter
thecoolwinter approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@thecoolwinter thecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution!

@thecoolwinter thecoolwinter merged commit 4707baa into CodeEditApp:main May 3, 2023
@thecoolwinter thecoolwinter mentioned this pull request May 3, 2023
Closed
6 tasks
@cengelbart39 cengelbart39 mentioned this pull request May 3, 2023
Merged
6 tasks
@bishabosha bishabosha deleted the feat/scala branch May 3, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecoolwinter thecoolwinter thecoolwinter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bishabosha @thecoolwinter