Added api route to get ssf contact for pantry #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanzzz368
reviewed
Oct 12, 2024
fanzzz368
reviewed
Oct 12, 2024
sam-schu
reviewed
Nov 3, 2024
There was a problem hiding this comment.
For me, the request does not work unless I remove both the interceptor decorator from the controller and the AuthGuard decorator from the new controller function.
There was a problem hiding this comment.
I agree that the path is confusing. Maybe something like users/ssf-contact/{pantryId}?
| @@ -27,4 +27,10 @@ export class UsersController { | |||
| removeUser(@Param('id') id: string) { | |||
| return this.usersService.remove(parseInt(id)); | |||
| } | |||
|
|
|||
| @UseGuards(AuthGuard('jwt')) | |||
| @Get('/pantries/:pantryId/ssf-contact') | |||
There was a problem hiding this comment.
Maybe it would make more sense to put this route under a pantries controller so that the path is just /pantries/{pantryId}/ssf-contact instead of with the users/ prefix? I know that this is getting a user in the end but the representative is kind of like an attribute of a specific pantry that we query for
nadishiro17
force-pushed
the
feature/get-pantry-contact
branch
from
508d3b8 to
fbd25a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Get SSF Contact Name for Pantry
📝 Description