What is NEFAC Home Page Section #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxn990
requested changes
Apr 8, 2025
| ? "bg-nefacblue text-white" | ||
| : "bg-white text-black border-4 border-nefacblue" | ||
| }`} | ||
| onClick={() => setFlipped(!isFront)} |
There was a problem hiding this comment.
🔧 I think we should use an onhover here, the idea being we see the second side of the card when the mouse is over the card, then we return to the original side
nefac-website/src/app/page.tsx
Outdated
| </video> | ||
| </div> | ||
| <div className="px-36 flex flex-row gap-7 w-full"> | ||
| <NefacFlipCard |
| <div className="px-36 pt-12 flex flex-row flex-wrap gap-4"> | ||
| <div className="z-0 pb-20"> | ||
| <CommentarySection /> | ||
| <div className="flex flex-col"> |
There was a problem hiding this comment.
🔧 Could we add this to a component? Like how we have the commentary section
| caption?: string; | ||
| imageBlue?: string; | ||
| imageWhite?: string; | ||
| links?: { text: string; url: string }[]; |
maxn990
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33
📝 Description
Created the "What is NEFAC?" section based on the figma design.
Briefly list the changes made to the code:
✔️ Verification
Visually verified the component matches the figma. I clicked on the video and it loaded, clicked on the cards to make sure they were flipping correctly.
🏕️ (Optional) Future Work / Notes
The sublinks on the back of the cards all link back to the home page. I was not sure what to link to for the card sub links.