Skip to content

kk-yes/no-toCheckbox #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

kk-yes/no-toCheckbox #117

wants to merge 6 commits into from

Conversation

kirtanakrishnan
Copy link
Contributor

ℹ️ Issue: Makes yes/no questions into one checkbox question.

Closes https://app.clickup.com/t/25czt68

📝 Description

Briefly list the changes made to the code:

  • Added support for this.
  • And removed redunant use of that.
  • Also this was included for reasons.

✔️ Verification

What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.

Provide screenshots of any new components, styling changes, or pages.

🏕️ (Optional) Future Work / Notes

Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!

Copy link
Contributor

@DerekL27 DerekL27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just drop the package-lock from tracking

@DerekL27 DerekL27 force-pushed the kk-yes/no-toCheckbox branch 2 times, most recently from 17c7ee0 to 6229bb0 Compare December 9, 2023 00:36
Copy link
Contributor

@leahzeisner leahzeisner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the SurveyForm.test.tsx file the test with "should call continueAndSaveResponses when the form is submitted with proper selections" is failing. It looks like the mock is not being called

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants