Support ubuntu 22.04 in released binaries #78
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Musl builds will solve this issue, thanks. |
|
However I believe #79 is a seperate issue, or at least I'm not sure how swapping to musl resolves it. |
|
Thanks for pointing this out, we have reopened #79 and answered on the dedicated issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently releases are compiled on the latest ubuntu release on github actions, currently this is ubuntu 24.04 but that will change in the future as new releases are made available.
This PR changes releases to be specifically built on ubuntu 22.04.
As a result of this change, cargo-codspeed binary releases will be compatible with both ubuntu 22.04 and ubuntu 24.04.
Whereas previously cargo-codspeed was only compatible with ubuntu 24.04.
This is because glibc is linked to the final binary and glibc is compatible only with the versions newer or the same as the version on the system it was built with.
Here is an example of the error hit when running on ubuntu 22.04:
As a workaround I am compiling cargo-codspeed from source, but it would be a nice boost to CI completion time if we could instead make use of the precompiled binaries.